Apply clang-format

[licanhua]

Fix #6658

Enforce the pipeline to check the clang-format.
User has four options to format files and apply clang-format correctly:

1. IDE integration. https://clang.llvm.org/docs/ClangFormat.html
2. npm run format in source/nodejs
3. powershell -ExecutionPolicy Bypass scripts\FormatSource.ps1 -ModifiedOnly $False in project root folder
4. If it fails the pipeline, you can download the patch like below, then run git apply downloadedfile

clang-format 12.0.0 or above is required.
FormatSource.ps1 used clang-format which is built into visual studio by default. so please update visual studio if you see clang-format is still 10.0
npmjs installed clang-format 14.0 automatically, so you only need to make npm install is run before npm run format

For Windows user, here is the process(a derivative of microsoft/MixedReality-GraphicsTools-Unreal)

1. After you checked out the repo, run scripts\SetupClangFormat.bat to setup the git hooks. It's an one time setup.
2. You edit and check in the code just as before. When you run git commit, the git hooks will verify the format for staged files
3. If there is format issue, commit will continue, but show the error and provide command to ask user to format the file
4. User format the files via powershell -ExecutionPolicy Bypass scripts\FormatSource.ps1 -ModifiedOnly $False -Path yourchangedfolder to format them before submitting the PR
5. Pipeline will detect the failures if there is format issue

Error example:

c:\repo\adaptivecards>PowerShell.exe -ExecutionPolicy Bypass scripts\FormatSource.ps1 -Verify $True -Path source
[clang-format] Checking formatting: C:\repo\adaptivecards\source\uwp\Renderer\dll\dll.cpp
C:\repo\adaptivecards\source\uwp\Renderer\dll\dll.cpp:11:7: error: code should be clang-formatted [-Wclang-format-violations]
STDAPI
      ^
Errors found (see output). Please make sure to resolve all issues before opening a Pull Request.
Formatting can be applied by running:
   PowerShell.exe -ExecutionPolicy Bypass C:\repo\adaptivecards\scripts\FormatSource.ps1 -ModifiedOnly $False [-Path <path to file or directory>]

c:\repo\adaptivecards>

violations on pipeline:

About .clang-format, refer to https://clang.llvm.org/docs/ClangFormatStyleOptions.html

Note: In this PR, pipeline check is disabled and files will be formatted in another PR.
If you want to review the difference between the formatted files and unformatted files, you can check
8d03136

Microsoft Reviewers: Open in CodeFlow

[ChrisGuzak]

consider committing the tools separate from the re-format.

[licanhua]

consider committing the tools separate from the re-format.

good call

[paulcam206]

I think we shouldn't delete source/shared/cpp/AdaptiveCardsSharedModel/AdaptiveCardsSharedModelUnitTest/.clang-format (or perhaps the new rules need to be updated), as clang-format does terrible things to our unit test code:

diff --git a/source/shared/cpp/AdaptiveCardsSharedModel/AdaptiveCardsSharedModelUnitTest/TextParsingTest.cpp b/source/shared/cpp/AdaptiveCardsSharedModel/AdaptiveCardsSharedModelUnitTest/TextParsingTest.cpp
index bc7c8afc3..fd02fdeed 100644
--- a/source/shared/cpp/AdaptiveCardsSharedModel/AdaptiveCardsSharedModelUnitTest/TextParsingTest.cpp
+++ b/source/shared/cpp/AdaptiveCardsSharedModel/AdaptiveCardsSharedModelUnitTest/TextParsingTest.cpp
@@ -7,49 +7,40 @@ using namespace Microsoft::VisualStudio::CppUnitTestFramework;
 using namespace AdaptiveCards;
 using namespace std::string_literals;

-namespace AdaptiveCardsSharedModelUnitTest
-{
-    TEST_CLASS(TextParsingTests)
-    {
-    public:
-        TEST_METHOD(HtmlEncodingPositiveTest)
-        {
-            const std::string textBlockText = _GetTextBlockText("\"Foo & Bar\" <[email protected]>");
-            const std::string expectedText = "\"Foo & Bar\" <[email protected]>";
-            Assert::AreEqual(expectedText, textBlockText, L"Make sure supported HTML entities are decoded");
-        }
+namespace AdaptiveCardsSharedModelUnitTest {
+TEST_CLASS(TextParsingTests){public : TEST_METHOD(HtmlEncodingPositiveTest){
+    const std::string textBlockText = _GetTextBlockText("\"Foo &amp; Bar\"&nbsp;&lt;[email protected]&gt;");
+const std::string expectedText = "\"Foo & Bar\" <[email protected]>";
+Assert::AreEqual(expectedText, textBlockText, L"Make sure supported HTML entities are decoded");
+} // namespace AdaptiveCardsSharedModelUnitTest

-        TEST_METHOD(HtmlEncodingAmpTest)
-        {
-            // we should be doing a single pass through HTML character encoding, so the resulting "&nbsp;" below
-            // shouldn't be further decoded to " "
-            const std::string textBlockText = _GetTextBlockText("&amp;nbsp;");
-            Assert::AreEqual("&nbsp;"s, textBlockText);
-        }
+TEST_METHOD(HtmlEncodingAmpTest)
+{
+    // we should be doing a single pass through HTML character encoding, so the resulting "&nbsp;" below
+    // shouldn't be further decoded to " "
+    const std::string textBlockText = _GetTextBlockText("&amp;nbsp;");
+    Assert::AreEqual("&nbsp;"s, textBlockText);
+}

-        // Test for strings that should roundtrip without modification
-        TEST_METHOD(HtmlEncodingRoundtripTests)
-        {
-            const std::vector<std::string> testStrings =
-                {
-                    "some test text",
-                    "&foo;",
-                    "&am p;"
-                };
+// Test for strings that should roundtrip without modification
+TEST_METHOD(HtmlEncodingRoundtripTests)
+{
+    const std::vector<std::string> testStrings = {"some test text", "&foo;", "&am p;"};

-            for (const auto& testString : testStrings)
-            {
-                const std::string textBlockText = _GetTextBlockText(testString);
-                Assert::AreEqual(testString, textBlockText);
-            }
-        }
+    for (const auto& testString : testStrings)
+    {
+        const std::string textBlockText = _GetTextBlockText(testString);
+        Assert::AreEqual(testString, textBlockText);
+    }
+}

-    private:
-        std::string _GetTextBlockText(const std::string& testString)
-        {
-            TextBlock textBlock;
-            textBlock.SetText(testString);
-            return textBlock.GetText();
-        }
-    };
+private:
+std::string _GetTextBlockText(const std::string& testString)
+{
+    TextBlock textBlock;
+    textBlock.SetText(testString);
+    return textBlock.GetText();
+}
+}
+;
 }

[almedina-ms]

defer the decision to remove clang-format npmjs