[2025June]Email retry logic #3761
Conversation
…te/wenjiefan/slice-419737
|
Issue #576349 is not valid. Please make sure you link an issue that exists, is open and is approved. |
…te/wenjiefan/email-retry-logic
…te/wenjiefan/email-retry-logic
| UpdateOutboxStatus(EmailOutbox, EmailOutbox.Status::Failed); | ||
|
|
||
| // if email is not rescheduled, it means it has exceeded the retry limit, stop retrying | ||
| if ClientTypeManagement.GetCurrentClientType() = CLIENTTYPE::Background then begin |
There was a problem hiding this comment.
@darjoo Can I assume all the emails sent in background belong to the CLIENTTYPE::Background ?
| RetryTime: DateTime; | ||
| RandomDelay: Integer; | ||
| begin | ||
| FeatureTelemetry.LogError('', EmailFeatureNameLbl, 'Retry failed email', StrSubstNo(FailedToFindEmailMessageMsg, EmailOutbox."Message Id"), '', Dimensions); |
There was a problem hiding this comment.
I remember Invoke-Miapp helps to auto fill the Log tag... But I tried it and it doesn't work. @darjoo do you know if we change anything in Invoke-Miapp? Is it a bug? :)
| FeatureTelemetry.LogError('', EmailFeatureNameLbl, 'Retry failed email', StrSubstNo(FailedToFindEmailMessageMsg, EmailOutbox."Message Id"), '', Dimensions); | ||
| EmailOutbox.Validate("Retry No.", EmailOutbox."Retry No." + 1); | ||
|
|
||
| if EmailOutbox."Retry No." > 10 then begin |
There was a problem hiding this comment.
Now I set maximum retry to 10 times Not sure if it is too much
| EmailOutbox.Status := EmailOutbox.Status::Queued; | ||
| EmailOutbox.Modify(); | ||
|
|
||
| RandomDelay := Random(5000); // Jitter - Random delay between 0 and 5000 milliseconds (5 seconds) |
There was a problem hiding this comment.
The jitter is 5 seconds. Now the concurrency is 10 at most. Do you think the jitter is too short?
| EmailOutbox.Modify(); | ||
|
|
||
| RandomDelay := Random(5000); // Jitter - Random delay between 0 and 5000 milliseconds (5 seconds) | ||
| RetryTime := CurrentDateTime() + EmailOutbox."Retry No." * 1.5 * 60000 + RandomDelay; // Base interval: 1.5 minutes, plus a random delay of up to 5 seconds |
There was a problem hiding this comment.
Maybe I should use 90000 directly....
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
| // ------------------------------------------------------------------------------------------------ | ||
|
|
There was a problem hiding this comment.
Should we add a page for this retry table? When user clicks on the retry No. , user can jump to the corresponding retry page with the filter on message Id.
| trigger OnValidate() | ||
| begin | ||
| if "Concurrency Limit" > 10 then | ||
| Error('The maximum value for Concurrency Limit is 10. Please set a lower value.'); |
There was a problem hiding this comment.
Make the error message to a label then it can be translated
| if EmailRateLimit.Get(AccountId, Connector) then | ||
| exit(EmailRateLimit."Concurrency Limit"); | ||
|
|
||
| EmailRateLimit."Account Id" := AccountId; |
| Description = 'The field is marked as internal in order to prevent modifying it from code.'; | ||
| } | ||
|
|
||
| field(10; "Date Queued"; DateTime) |
There was a problem hiding this comment.
Looks we don't need the DateQueued
There was a problem hiding this comment.
DateSending and DateFailed should be enough
| var | ||
| EmailOutbox: Record "Email Outbox"; | ||
| begin | ||
| EmailOutbox.SetRange(Status, EmailOutbox.Status::Processing); |
There was a problem hiding this comment.
I checked the code, EmailOutbox.Status::Processing should represent the emails are being sent.
Just for confirmation, EmailOutbox.Status::Queued should not be included here because queued email has not been processed.
Summary
Work Item(s)
Fixes AB#576349