Skip to content

Conversation

adrogin
Copy link
Contributor

@adrogin adrogin commented Sep 11, 2025

Summary

New method in the SignedXml codeunit to add KeyInfo clause to the signature from an X509 certificate.
Key info contains the X509Data element conforming to the W3C XML signature syntax.

Work Item(s)

Resolves #4135

Fixes AB#608915

@adrogin adrogin requested a review from a team as a code owner September 11, 2025 06:47
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Sep 11, 2025
@adrogin
Copy link
Contributor Author

adrogin commented Sep 11, 2025

@WaelAbuSeada, please review.

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Sep 15, 2025
@WaelAbuSeada
Copy link
Member

WaelAbuSeada commented Sep 29, 2025

@WaelAbuSeada, please review.

I am mostly fine with this, can you get this to build correctly, then I will sign off?
adrogin

@adrogin
Copy link
Contributor Author

adrogin commented Oct 2, 2025

@WaelAbuSeada Thanks a lot! I'm not sure though, why the build failed - the error message does not look very informative. I updated the branch and pushed again, but now the PR waiting for the approval to start the workflow.

@JesperSchulz
Copy link
Contributor

@WaelAbuSeada Thanks a lot! I'm not sure though, why the build failed - the error message does not look very informative. I updated the branch and pushed again, but now the PR waiting for the approval to start the workflow.

I'll reinitiate the build :-)

@JesperSchulz JesperSchulz added the Linked Issue is linked to a Azure Boards work item label Oct 2, 2025
@github-actions github-actions bot added this to the Version 28.0 milestone Oct 2, 2025
@adrogin
Copy link
Contributor Author

adrogin commented Oct 6, 2025

@WaelAbuSeada Thanks a lot! I'm not sure though, why the build failed - the error message does not look very informative. I updated the branch and pushed again, but now the PR waiting for the approval to start the workflow.

I'll reinitiate the build :-)

Thanks a lot! But it's failing again. Can we see the actual compiler error? All I see now is a reference to BCContainerHelper which doesn't help me to pinpoint the issue. And of course I can build the app and run the tests in my container locally.

[Test]
procedure SignXmlDocumentAddKeyInfoInSignature()
var
SignedXml: Codeunit SignedXml;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SignedXml is a global var. was a bit hidden:
Error: AA0198 The name of the local variable 'SignedXml' is identical to a global variable.

@WaelAbuSeada
Copy link
Member

@WaelAbuSeada Thanks a lot! I'm not sure though, why the build failed - the error message does not look very informative. I updated the branch and pushed again, but now the PR waiting for the approval to start the workflow.

I'll reinitiate the build :-)

Thanks a lot! But it's failing again. Can we see the actual compiler error? All I see now is a reference to BCContainerHelper which doesn't help me to pinpoint the issue. And of course I can build the app and run the tests in my container locally.

Ping me when you fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SignedXml codeunit is missing a method to add the X509Data node from an RSA key

3 participants