-
Notifications
You must be signed in to change notification settings - Fork 257
New method to add KeyInfo clause to SignedXml from X509 certificate #4749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@WaelAbuSeada, please review. |
I am mostly fine with this, can you get this to build correctly, then I will sign off? |
@WaelAbuSeada Thanks a lot! I'm not sure though, why the build failed - the error message does not look very informative. I updated the branch and pushed again, but now the PR waiting for the approval to start the workflow. |
I'll reinitiate the build :-) |
Thanks a lot! But it's failing again. Can we see the actual compiler error? All I see now is a reference to BCContainerHelper which doesn't help me to pinpoint the issue. And of course I can build the app and run the tests in my container locally. |
[Test] | ||
procedure SignXmlDocumentAddKeyInfoInSignature() | ||
var | ||
SignedXml: Codeunit SignedXml; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SignedXml is a global var. was a bit hidden:
Error: AA0198 The name of the local variable 'SignedXml' is identical to a global variable.
Ping me when you fix it |
Summary
New method in the SignedXml codeunit to add KeyInfo clause to the signature from an X509 certificate.
Key info contains the X509Data element conforming to the W3C XML signature syntax.
Work Item(s)
Resolves #4135
Fixes AB#608915