Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following behavior:
NOTE There is one case in which the above logic does not hold. When previously using a custom userId, and then clearing it out in the settings page, and then starting a new conversation, that previous custom user id is still used. This is because it was set as both the previous id and the custom id, so the logic falls back to the previous id.
Due to the fragility and complexity of the start conversation logic, I feel that it's not worth it to try to accommodate this case because it is easily avoided by restarting the conversation again with a new user id. We also have plans in the near future to simplify this logic, so we can implement this behavior at that time.