Fixed OAuth card prompt flow #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
justinwilaby
as code owners
tonyanziano
force-pushed
the
toanzian/auth
branch
from
01b96b8 to
1c089ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544
===
This will fix the issue users were having when trying to authenticate via an OAuth prompt card as seen in samples 18 and 24.
ngrok.tshas been rewritten so that instead of being a singleton, it is now a class that can be instantiated multiple times to represent individual ngrok instances.This fix checks to see if ngrok is already running when generating the postback URL for the OAuth sign in flow. If ngrok is already running, then that ngrok URL is used as the postback URL, if not, we start up a separate ngrok instance solely for the purpose of generating a URL that can be used as the postback URL. If we started up the separate ngrok instance for OAuth, we tear it down once the token response is received from the Bot Framework token server.