#1743 - Fix endpoint notify text color #1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corinagum
requested review from
a-b-r-o-w-n,
compulim,
cwhitten and
tonyanziano
as code owners
|
Check this on High Contrast, I'm pretty sure it's going to be invisible because the HC dialog background is black. |
:-( well in HC if it was black background it would need to switch to White... seems like it should go to a white background vs. black? |
corinagum
changed the title
|
@DesignPolice in HC we used to have light-themed dialogs with an #F4F4F4 background, but we switched away from that. We could discuss going back to that model if it makes more sense from a design standpoint. |
tonyanziano
reviewed
Sep 4, 2019
packages/sdk/ui-react/src/widget/autoComplete/autoComplete.scss
Outdated
Show resolved
Hide resolved
…ulator into corinagum/1743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1743
Previously the endpoint notification text for opening a bot was showing as a low-contrast yellow. I fixed the text to a dark grey per @DesignPolice. Since the openBotDialog and botCreationDialog components were displaying different colors for these texts, I made both of them dark grey.
High Contrast:
(And for sanity, Dark:)
