Fixed unnecessary Web Chat re-renders caused by interaction with activities #1930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
force-pushed
the
toanzian/adaptive-fix
branch
from
2a3cc9a to
b6e4613
Compare
tonyanziano
requested review from
a-b-r-o-w-n,
compulim,
corinagum and
cwhitten
as code owners
|
Should be all good now |
tonyanziano
force-pushed
the
toanzian/adaptive-fix
branch
from
b6e4613 to
945d084
Compare
corinagum
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1701
===
Web Chat was being completely re-rendered, which was causing Adaptive Card state to be wiped. The following interactions with Web Chat would cause this:
The fix prevents these re-renders by fixing the way app state was being plumbed through the components.
The entire
documentobject is no longer plumbed down through theemulator.tsxcomponent and its children. Instead,documentIdis plumbed through these components, and then each component uses this id to fetch whatever relevant information from the store that it needs.Also added
electron-devtools-installerwhich resolves #1650 , and adds React Dev Tools as well as Redux Dev Tools.===
Still need to add / fix tests.