ArrayPool can be larger than requested resulting in freeing uninitialized GCHandles #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's currently blocking this PR from being merged? Our error logs are full of handle not initialised errors due to this, and we had to downgrade to 0.3.162 for the time being, so it would be nice for this to get fixed! |
|
+1 We've been stuck on 0.3.162 for seven months now. This PR has gone five months without comment from the maintainers. @copilot can you help with this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generator assumes the array returned from ArrayPool is exactly the size requested, but in reality it can be larger, resulting in freeing uninitialized GCHandles which throws.
Fix this by switching to for loop instead of foreach.