NRE if RequestBody.Extensions is set to null

[Tasteful]

The RequestBody.Extensions is initiated with a dictionary but if this is set to null the following line will throw an NullReferenceException that is very hard to track down without any pointer of what the source object it is.

OpenAPI.NET/src/Microsoft.OpenApi/Models/OpenApiOperation.cs

Line 260 in 2db9643

Extensions = RequestBody.Extensions.ToDictionary(k => k.Key, v => v.Value) // Clone extensions so we can remove the x-bodyName extensions from the output V2 model.

[darrelmiller]

Extensions is initialized to an empty dictionary so I am assuming this error only happens when someone explicitly sets the Extensions to null. Is there a valid reason for doing this, or should we prevent people from setting extensions to be null?

[Tasteful]

I don't remember why I was setting it to null in the first case, but when I upgraded the OpenAPI package it was a change in the behavior that was hard to track down to this row and I was needing to checkout the source for the OpenAPI package and execute my code with.

Either a proper null-check should be used or the property should throw exception if null-value is set. Removing the property-set is a breaking change so I think that should be avoided.