Generate changelogs per release #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
approved these changes
Jul 6, 2021
| @@ -169,14 +177,9 @@ export function generate(): string { | |||
| } | |||
|
|
|||
| const output = outputs.join("\n\n"); | |||
|
|
|||
| if (!output.length) { | |||
There was a problem hiding this comment.
Could you move this logic to the caller?
sandersn
reviewed
Jul 6, 2021
deploy/deployChangedPackages.mjs
Outdated
|
|
||
| console.log("\n# Release notes:"); |
There was a problem hiding this comment.
I don't know the code well enough -- but it looks like this prints the release notes but doesn't upload them. Is that the intent?
There was a problem hiding this comment.
It does! I just figured it'd be nice to have that in the CI logs also
|
OK, this is updated to use the git tags and all feedback is resolved 👍🏻 |
saschanaz
approved these changes
Jul 9, 2021
deploy/deployChangedPackages.mjs
Outdated
| // This assumes we'll only _ever_ ship patches, which may change in the | ||
| // future someday. | ||
| const [maj, min, patch] = pkgJSON.version.split("."); | ||
| const olderVersion = `${maj}.${min}.${patch - 1}`; |
There was a problem hiding this comment.
(Just to note for future reference: git describe --tags --match "@types/web@*" --abbrev=0 can do the same thing)
Co-authored-by: Kagami Sascha Rosylight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for re-using the CHANGELOG infra for the releases - https://github.com/microsoft/TypeScript-DOM-lib-generator/releases