Skip to content

Update README to match the new code #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 30, 2021
Merged

Conversation

saschanaz
Copy link
Contributor

This should match better with the code after #1034.

This should match better with the code after microsoft#1034.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2021

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor Author

@orta @sandersn Do you see something to add or modify here? 👀

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure about the removal of heuristics, which still somewhat apply. @orta can you take a look too?


### What are the TypeScript team's heuristics for PRs to the DOM APIs

Changes to this repo can have pretty drastic ecosystem effects, because these types are included by default in TypeScript.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph is mostly still true, right? I know we are less conservative than before, but the idea is that every update to @types/web will eventually ship with Typescript by default means that there are some changes that will not be OK until there's a way to publish other packages from here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maybe it's good to keep the sentence for maintainers. It has minimal meaning for contributors though, since nearly all changes will now be from webref and MDN rather than manual PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we are less conservative than before

I'm not sure, as quite a lot types are removed for lack of broad browser support?

Co-authored-by: Nathan Shively-Sanders <[email protected]>
Copy link
Contributor

@orta orta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, yeah, I think this probably what we want

@saschanaz
Copy link
Contributor Author

saschanaz commented Jul 27, 2021

Cool, I'd like to merge this if @sandersn also agrees.

@saschanaz
Copy link
Contributor Author

LGTM

@github-actions github-actions bot merged commit 2652c3b into microsoft:main Jul 30, 2021
@github-actions
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants