Skip to content

Revert "fix: update alert method signature to accept string type" #2015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Revert "fix: update alert method signature to accept string type" #2015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28394,7 +28394,7 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/window) */
readonly window: Window & typeof globalThis;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/alert) */
alert(message?: string): void;
alert(message?: any): void;
/**
* @deprecated
*
Expand Down Expand Up @@ -30047,7 +30047,7 @@ declare var visualViewport: VisualViewport | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/window) */
declare var window: Window & typeof globalThis;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/alert) */
declare function alert(message?: string): void;
declare function alert(message?: any): void;
/**
* @deprecated
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28372,7 +28372,7 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/window) */
readonly window: Window & typeof globalThis;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/alert) */
alert(message?: string): void;
alert(message?: any): void;
/**
* @deprecated
*
Expand Down Expand Up @@ -30025,7 +30025,7 @@ declare var visualViewport: VisualViewport | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/window) */
declare var window: Window & typeof globalThis;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/alert) */
declare function alert(message?: string): void;
declare function alert(message?: any): void;
/**
* @deprecated
*
Expand Down
4 changes: 2 additions & 2 deletions baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28394,7 +28394,7 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/window) */
readonly window: Window & typeof globalThis;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/alert) */
alert(message?: string): void;
alert(message?: any): void;
/**
* @deprecated
*
Expand Down Expand Up @@ -30047,7 +30047,7 @@ declare var visualViewport: VisualViewport | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/window) */
declare var window: Window & typeof globalThis;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/alert) */
declare function alert(message?: string): void;
declare function alert(message?: any): void;
/**
* @deprecated
*
Expand Down
2 changes: 1 addition & 1 deletion inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@
"method": {
"alert": {
"overrideSignatures": [
"alert(message?: string): void"
"alert(message?: any): void"
]
},
"postMessage": {
Expand Down