Add back element tag name map #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falsandtru
reviewed
Nov 21, 2017
| @@ -831,6 +831,10 @@ module Emit = | |||
| Pt.Printl "}" | |||
| Pt.Printl "" | |||
|
|
|||
| let EmitElementTagNameMap () = | |||
| Pt.Printl "interface ElementTagNameMap extends HTMLElementTagNameMap, SVGElementTagNameMap { }" | |||
There was a problem hiding this comment.
Should extend only HTMLElementTagNameMap. If not, we can't define other SVG elements such as SVGAElement by extending the interface. So ElementTagNameMap should be just an alias of HTMLElementTagNameMap. This is a reasonable compromise as you said.
extends HTMLElementTagNameMap { }
There was a problem hiding this comment.
And ElementTagNameMap should be marked as deprecated.
|
Why you don't update DefinitelyTyped? |
The only way i could think of is adding some forward references to the new types.. but this seems ugly.. This also indicates that there are other users for the type out there.. having the type in the library is better than breaking users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#326 removed
ElementTagNameMap. turns our types in Definitelytyped depended on it. Putting it back.