fix: add escape to CSS

[alan-agius4]

Closes: microsoft/TypeScript#21090

[alan-agius4]

to be honest I am not sure 100% that the value should be a string as while the input is a DOMString from the example it seems that It can accept a number.
Example

CSS.escape(".foo#bar")        // "\.foo\#bar"
CSS.escape("()[]{}")          // "\(\)\[\]\{\}"
CSS.escape('--a')             // "--a"
CSS.escape(0)                 // "\30 ", the Unicode code point of '0' is 30
CSS.escape('\0')              // "\ufffd", the Unicode REPLACEMENT CHARACTER

[mhegazy]

The file is automatically generated. please make your edits in https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/overridingTypes.json instead.
See https://github.com/Microsoft/TSJS-lib-generator#contribution-guidelines for more details.

[alan-agius4]

@mhegazy

Question: I noticed that the CSS.escape is a WD (https://developer.mozilla.org/en-US/docs/Web/API/CSS/escape) and based on https://github.com/Microsoft/TSJS-lib-generator#contribution-guidelines. It shouldn't be added here either correct?

[mhegazy]

We have been accepting these lately.

[alan-agius4]

I think you the new method should go in addedTypes.json rather than overridingTypes.json as this method is not yet declared.

However, when I do so I end up with something like this;

interface CSS {
    escape(value: string): string;
}

declare var CSS: {
    supports(property: string, value?: string): boolean;
};

Maybe you can point me to the right direction?

[mhegazy]

yes. you are correct, addedTypes is the right place.