fix: add escape to CSS
#371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
commented
Feb 12, 2018
| @@ -1819,9 +1819,12 @@ declare var CryptoKeyPair: { | |||
| }; | |||
|
|
|||
| interface CSS { | |||
There was a problem hiding this comment.
I'd expect that the generated output is like the following;
interface CSS {
supports(property: string, value?: string): boolean;
escape(value: string): string;
}
declare var CSS: CSS;However I cannot seem to make it like that.
There was a problem hiding this comment.
the generation script is not handling added static properties correctly.. i think i have a fix for that.
alan-agius4
force-pushed
the
feature/css-escape-method
branch
from
a1bb17d to
032e357
Compare
|
This is still a draft. Really ready to be included? |
|
Should be fixed by #383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
microsoft/TypeScript#21090