-
Notifications
You must be signed in to change notification settings - Fork 440
Add XMLHttpRequest types #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| [Exposed=(Window,DedicatedWorker,SharedWorker)] | ||
| interface XMLHttpRequestEventTarget : EventTarget { | ||
| // event handlers | ||
| attribute EventHandler onloadstart; | ||
| attribute EventHandler onprogress; | ||
| attribute EventHandler onabort; | ||
| attribute EventHandler onerror; | ||
| attribute EventHandler onload; | ||
| attribute EventHandler ontimeout; | ||
| attribute EventHandler onloadend; | ||
| }; | ||
|
|
||
| [Exposed=(Window,DedicatedWorker,SharedWorker)] | ||
| interface XMLHttpRequestUpload : XMLHttpRequestEventTarget { | ||
| }; | ||
|
|
||
| enum XMLHttpRequestResponseType { | ||
| "", | ||
| "arraybuffer", | ||
| "blob", | ||
| "document", | ||
| "json", | ||
| "text" | ||
| }; | ||
|
|
||
| [Constructor, | ||
| Exposed=(Window,DedicatedWorker,SharedWorker)] | ||
| interface XMLHttpRequest : XMLHttpRequestEventTarget { | ||
| // event handler | ||
| attribute EventHandler onreadystatechange; | ||
|
|
||
| // states | ||
| const unsigned short UNSENT = 0; | ||
| const unsigned short OPENED = 1; | ||
| const unsigned short HEADERS_RECEIVED = 2; | ||
| const unsigned short LOADING = 3; | ||
| const unsigned short DONE = 4; | ||
| readonly attribute unsigned short readyState; | ||
|
|
||
| // request | ||
| void open(ByteString method, USVString url); | ||
| void open(ByteString method, USVString url, boolean async, optional USVString? username = null, optional USVString? password = null); | ||
| void setRequestHeader(ByteString name, ByteString value); | ||
| attribute unsigned long timeout; | ||
| attribute boolean withCredentials; | ||
| [SameObject] readonly attribute XMLHttpRequestUpload upload; | ||
| void send(optional (Document or BodyInit)? body = null); | ||
| void abort(); | ||
|
|
||
| // response | ||
| readonly attribute USVString responseURL; | ||
| readonly attribute unsigned short status; | ||
| readonly attribute ByteString statusText; | ||
| ByteString? getResponseHeader(ByteString name); | ||
| ByteString getAllResponseHeaders(); | ||
| void overrideMimeType(DOMString mime); | ||
| attribute XMLHttpRequestResponseType responseType; | ||
| readonly attribute any response; | ||
| readonly attribute USVString responseText; | ||
| [Exposed=Window] readonly attribute Document? responseXML; | ||
| }; | ||
| typedef (File or USVString) FormDataEntryValue; | ||
|
|
||
| [Constructor(optional HTMLFormElement form), | ||
| Exposed=(Window,Worker)] | ||
| interface FormData { | ||
| void append(USVString name, USVString value); | ||
| void append(USVString name, Blob blobValue, optional USVString filename); | ||
| void delete(USVString name); | ||
| FormDataEntryValue? get(USVString name); | ||
| sequence<FormDataEntryValue> getAll(USVString name); | ||
| boolean has(USVString name); | ||
| void set(USVString name, USVString value); | ||
| void set(USVString name, Blob blobValue, optional USVString filename); | ||
| iterable<USVString, FormDataEntryValue>; | ||
| }; | ||
| [Constructor(DOMString type, optional ProgressEventInit eventInitDict), | ||
| Exposed=(Window,DedicatedWorker,SharedWorker)] | ||
| interface ProgressEvent : Event { | ||
| readonly attribute boolean lengthComputable; | ||
| readonly attribute unsigned long long loaded; | ||
| readonly attribute unsigned long long total; | ||
| }; | ||
|
|
||
| dictionary ProgressEventInit : EventInit { | ||
| boolean lengthComputable = false; | ||
| unsigned long long loaded = 0; | ||
| unsigned long long total = 0; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
thistype was intentional see microsoft/TypeScript#15101 and #275There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
XMLHttpRequestUploadalso extendsXMLHttpRequestEventTarget, hmm. It doesn't have any properties so forcing XMLHttpRequest won't be an issue for now...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done