customElement.define's 2nd parameter is a constructor #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was a call signature, but this is not correct.
sandersn
changed the title
sandersn
changed the title
|
@saschanaz I'm going to merge this since I'm pretty sure it's right based on usage from MDN's example repo, but if you have comments, please do chime in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was a call signature, but this is not correct. I'm not sure if
HTML - Custom Elements.widlis wrong or whether our interpretation of it is wrong. A call signature does not match actual usage or the semantics as implemented by Chrome, however.