protocol.d.ts should define constants for kind and kindModifiers

[dbaeumer]

The current documentation list examples, but without a definition clients can't know about the set of valid kinds and kindModifiers.

[dbaeumer]

There is also a problem in the documentation. For example CompletionEntry states for the kind values like className or parameterName. However the values are class and parameter. To my knowledge these values map to the values of ScriptElementKind

[steveluc]

Great points. Will fix.

[dbaeumer]

Strings can't be defined in .d.ts. So we might need a protocol.consts.ts

[steveluc]

protocol.d.ts is a good example for string enums.

[DanielRosenwasser]

I think we should consider filing future issues like this on the TypeScript repo itself, but since we're discussing here, let's continue.

Not really sure where I see the example of how to do this in protocol.d.ts. I think @dbaeumer's point about constants still stands. For instance, I'll be working on getDocumentHighlights server support soon and I'm sort of just left with explicitly stating the values within the documentation in protocol.d.ts.