Configurable error visibility options and gutter errors tooltip #726
Conversation
… more visible outlining of errors Also adds a gutter tooltip to show all errors on a line
|
|
Fix typo Co-Authored-By: Orta <[email protected]>
|
👍 |
|
I have tried this configs but did not work!!!! |
|
@betorobson What exactly is not working? Are you getting an error? Is it just the config options that don't do anything? Obviously assume you're actually running this code. |
|
I would like to use a outlined error lint instead the squiggly, also I would like to see a circle in gutter but the only property that works is the color. Look my screenshot, you can see at left panel my source code with squiggly errors and at right panel my Typescript settings.
|
|
@betorobson Are you actually running the code from master? This PR has been merged, but a new version has not yet been released. |
|
Yes, I assumed that is was working because it is in master branch README. |
|
@betorobson Sorry, I'm still not clear from what you're saying if you're positively running this code or not. If I use your settings with this code, it works as expected. |
|
I'm using the last version 3.6.2. As you told me, the settings that i'm trying are only in master branch. Do you have any idea when it will be published? |
| @@ -5,5 +5,7 @@ | |||
|
|
|||
| // empty string, or one of "region.redish", "region.orangish", "region.yellowish", "region.greenish", "region.bluish", "region.purplish", "region.pinkish" | |||
| "error_color": "", | |||
| "error_icon": "", | |||
There was a problem hiding this comment.
This means there's always a default, which means users haven't been seeing errors since we sent out the update last week.
| settings.get("error_color", "invalid.illegal"), | ||
| settings.get("error_icon", ""), | ||
| sublime.DRAW_OUTLINED | ||
| if settings.get("error_outlined") else | ||
| sublime.DRAW_NO_FILL + | ||
| sublime.DRAW_NO_OUTLINE + |
There was a problem hiding this comment.
+ is wrong, so this has never worked...
Implements two additional configuration options, one for setting an optional gutter icon on lines with errors and one for switching from default squiggly line to solid outline. This is superset of PR #625 functionality.
Also adds a gutter tooltip to show all errors on a line.
Fixes #522 #711
Thoughts and feedback welcome.