Skip to content

Unnecessary highlight "in" and "var" #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhegazy opened this issue Sep 16, 2016 · 4 comments
Closed

Unnecessary highlight "in" and "var" #261

mhegazy opened this issue Sep 16, 2016 · 4 comments

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Sep 16, 2016

From @waderyan on September 16, 2016 20:28

From @LongQue on September 16, 2016 9:38

  • VSCode Version:1.5.2
  • OS Version:Windows 10
  • Language:Typescript

"in" in the next picture is highlighted, but it's unnecessary.
I have found a few bugs about highlight, so I think maybe there are or will be still other bugs about it.

6

Copied from original issue: microsoft/vscode#12136

Copied from original issue: microsoft/TypeScript#10956

@mhegazy
Copy link
Contributor Author

mhegazy commented Sep 16, 2016

From @waderyan on September 16, 2016 20:28

From @LongQue on September 16, 2016 9:55

It appeared again just now. But it's unnecessary highlight "var".
7

@mhegazy
Copy link
Contributor Author

mhegazy commented Sep 16, 2016

From @waderyan on September 16, 2016 20:28

@LongQue thank you for opening this issue. There are a number of fixes coming out soon around the out of the box grammar. Many have found the Atom JavaScript grammar as an excellent fix to these problems in the meantime.

As this issue falls on the TypeScript language service I am migrating the issue there.

@mhegazy
Copy link
Contributor Author

mhegazy commented Sep 16, 2016

Colorization issues are tracked in https://github.com/Microsoft/TypeScript-TmLanguage

@sheetalkamat
Copy link
Member

Fixed by #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants