Skip to content

Unnecessary highlight "in" and "var" #10956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
waderyan opened this issue Sep 16, 2016 · 4 comments
Closed

Unnecessary highlight "in" and "var" #10956

waderyan opened this issue Sep 16, 2016 · 4 comments
Labels
VS Code Tracked There is a VS Code equivalent to this issue

Comments

@waderyan
Copy link

From @LongQue on September 16, 2016 9:38

  • VSCode Version:1.5.2
  • OS Version:Windows 10
  • Language:Typescript

"in" in the next picture is highlighted, but it's unnecessary.
I have found a few bugs about highlight, so I think maybe there are or will be still other bugs about it.

6

Copied from original issue: microsoft/vscode#12136
@waderyan waderyan self-assigned this Sep 16, 2016
@waderyan
Copy link
Author

From @LongQue on September 16, 2016 9:55

It appeared again just now. But it's unnecessary highlight "var".
7

@waderyan
Copy link
Author

@LongQue thank you for opening this issue. There are a number of fixes coming out soon around the out of the box grammar. Many have found the Atom JavaScript grammar as an excellent fix to these problems in the meantime.

As this issue falls on the TypeScript language service I am migrating the issue there.

@waderyan waderyan mentioned this issue Sep 16, 2016
Closed
@waderyan waderyan removed their assignment Sep 16, 2016
@waderyan waderyan added the VS Code Tracked There is a VS Code equivalent to this issue label Sep 16, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Sep 16, 2016

Colorization issues are tracked in https://github.com/Microsoft/TypeScript-TmLanguage

@mhegazy mhegazy mentioned this issue Sep 16, 2016
Closed
@mhegazy
Copy link
Contributor

mhegazy commented Sep 16, 2016

This issue was moved to microsoft/TypeScript-TmLanguage#261

@mhegazy mhegazy closed this as completed Sep 16, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waderyan @mhegazy