Multiline JSDoc Types

[mjbvz]

From microsoft/vscode#27777

TS and JS Grammar Extension version: 0.0.20

Code

/**
 * @param {{
 *  z: number
 * }} x
 */
function foo(x){}

Current highlighting:

There seems to be some debate about whether this is supported or not: jscs-dev/node-jscs#245 but it seems closure supports this syntax

[sheetalkamat]

We used the jsdoc grammar from https://github.com/atom/language-javascript. Please file the issue there and once fixed we will pick it up. Thank you.

[Raynos]

Can we re-open this issue ? The upstream repository is not maintained anymore ( atom/language-javascript#645 (comment) )

Any changes to the jsdoc grammar to support multiline syntax highlighting wil lhave to be made directly in this repository.

[jeremyjacob]

Seconded. The issue is still present, despite support for multiline JSDoc types at the LSP level.

[myfonj]

+1. Rephrasing info from linked issue (microsoft/vscode#206516), even simple line break before closing */ of "line" JSDoc comment makes it appear like a normal insignificant comment:

/** @type {string} */
var a = "OK, highlighted as JSDoc.";
/** @type {string}
*/
var b = "ERROR, highlighted like a regular comment.";

Produces:

And this code monster demonstrating that LSP crunches it without a problem, but highlighter fails:

// @ts-check

/** @typedef
    * {
    typeof
    * ABC [
         number
    * ]
    }
           *       Ch -
   this
 - still
 * works
*/
// ↑ ERROR, highlighted as a comment, but processed

const ABC = /** @type {const} */(["a", "b", "c"]);
	
/** @type {Ch}
*/
// ↑ ERROR, highlighted as a comment, but processed
var x = 'd';

/** @type {Ch} */
// ↑ OK, highlighted
var y = 'd';