Skip to content

Add primitive types null, true, and false #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

poke
Copy link

@poke poke commented Sep 8, 2016

Starting with TypeScript 2, we can use all kinds of literal types. These three are very common literal types which also happen to be reserved words, so I guess it makes sense to handle them in a special way.

Ultimately, it might make sense to expand the syntax structure for literal types a bit but for now, this is a quick fix.

@msftclas
Copy link

msftclas commented Sep 8, 2016

Hi @poke, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mhegazy
Copy link
Contributor

mhegazy commented Sep 16, 2016

@poke, sorry for the delay. Can you refresh the PR.

@sheetalkamat
Copy link
Member

@mhegazy and @poke you shouldn't need this change any more as #257 handles this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants