support namespaced tsx #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sheetalkamat
requested changes
Jan 17, 2018
| ^ | ||
| source.tsx | ||
| >const valid2 = <namespaced:tag namespaced:boolean-attr>foo</namespaced:tag>; | ||
| ^^^^^ |
There was a problem hiding this comment.
:tag and :boolean-attr is getting scoped here instead of just tag and boolean-attr
There was a problem hiding this comment.
It was intended, to highlight the colon the same color as the rest of the tag/attribute.
Would you prefer the colon to have its own scope? (punctuation.separator.namespace.tsx?)
| @@ -0,0 +1,9 @@ | |||
| const valid1 = <standard-tag standard-attribute="foo" />; | |||
There was a problem hiding this comment.
Add comment // @onlyOwnGrammar - As this has jsx at the top to avoid scoping this for TypeScript without react support.
sheetalkamat
approved these changes
Mar 2, 2018
sheetalkamat
requested changes
Mar 2, 2018
|
✓ |
sheetalkamat
approved these changes
Mar 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for namespaced tsx as per jsx specification.
This is not a breaking change. All tests are green, I added an additional test for good measure.
The change is pretty simple, but it ends up being quite big due to the sheer amount of similar regexes:
A namespaced tag or attribute is defined by an identifier (namespace), followed by a colon, followed by another identifier (name), which gives us this addition: