Merge pull request #3 from microsoft/v2

Pull form forks

Author: 0length

.github/CODEOWNERS

@@ -48,3 +48,10 @@ packages/tsconfig-reference/copy/uk/**/*.md @AMashoshyna [translation] [uk]
 packages/typescriptlang-org/src/copy/uk/**/*.ts @AMashoshyna [translation] [uk]
 packages/typescriptlang-org/src/copy/uk.ts @AMashoshyna [translation] [uk]
 packages/documentation/copy/uk/**/*.md @AMashoshyna [translation] [uk]
+
+# Collaborators for Polish Translation of the Website
+packages/playground-examples/copy/pl @msieroslawska @TomWebwalker [translation] [pl]
+packages/tsconfig-reference/copy/pl/**/*.md @msieroslawska @TomWebwalker [translation] [pl]
+packages/typescriptlang-org/src/copy/pl/**/*.ts @msieroslawska @TomWebwalker [translation] [pl]
+packages/typescriptlang-org/src/copy/pl.ts @msieroslawska @TomWebwalker [translation] [pl]
+packages/documentation/copy/pl/**/*.md @msieroslawska @TomWebwalker [translation] [pl]

.github/workflows/CI.yml

@@ -2,7 +2,7 @@ name: CI
 on: pull_request
 
 jobs:
-  test:
+  tests:
     runs-on: ubuntu-latest
 
     steps:
@@ -41,57 +41,44 @@ jobs:
       - run: yarn bootstrap
       - run: yarn workspace typescriptlang-org build
 
-      #  Blocked on https://github.com/Azure/static-web-apps/issues/147
-      #
-
-      # PR deploys via static web apps
-      # - name: "Make a fake 'app' for the azure project of the static HTML"
-      #   run: |
-      #     mkdir fakeapp
-      #     mv packages/typescriptlang-org/public fakeapp/public
-      #     ls fakeapp
-      #     ls fakeapp/public
-      #     echo '{ "name": "fake", "scripts": { "build": "" } }' > fakeapp/package.json
-
-      # - name: Build And Deploy
-      #   id: builddeploy
-      #   uses: Azure/[email protected]
-      #   if: github.event.base.repo.id == github.event.head.repo.id
-      #   with:
-      #     azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_NICE_MEADOW_0C9756810 }}
-      #     repo_token: ${{ secrets.GITHUB_TOKEN }}
-      #     action: "upload"
-      #     app_location: "fakeapp"
-      #     api_location: "api"
-      #     app_artifact_location: "public"
-
       # Verify it compiles
       - run: yarn compile
       # Run all the package's tests
       - run: yarn test
         env:
           CI: true
 
-      - name: "Validates that TypeScript plugins work"
-        run: npm init typescript-playground-plugin playground-my-plugin
-
       # danger for PR builds
       - if: github.event_name == 'pull_request' && github.event.base.repo.id == github.event.head.repo.id
         run: "yarn danger ci"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           PR_DEPLOY_URL_ROOT: ${{ steps.deploy.outputs.static_web_app_url }}
-  #
-  #  Blocked on https://github.com/Azure/static-web-apps/issues/147
-  #
-  # close_pull_request_job:
-  #   if: github.event_name == 'pull_request' && github.event.action == 'closed' && github.event.base.repo.id == github.event.head.repo.id
-  #   runs-on: ubuntu-latest
-  #   name: Close Pull Request Job
-  #   steps:
-  #     - name: Close Pull Request
-  #       id: closepullrequest
-  #       uses: Azure/[email protected]
-  #       with:
-  #         azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_NICE_MEADOW_0C9756810 }}
-  #         action: "close"
+
+      - name: "Validates that TypeScript plugins work"
+        run: |
+          cd ..
+          npm init typescript-playground-plugin playground-my-plugin
+
+  windows:
+    runs-on: windows-latest
+
+    steps:
+      # Check out, and set up the node infra
+      - uses: actions/checkout@v1
+      - uses: actions/setup-node@v1
+        with:
+          node-version: "13.x"
+
+      # Get local dependencies
+      - run: yarn install
+        env:
+          YARN_CHECKSUM_BEHAVIOR: ignore
+
+      - run: yarn bootstrap
+      - run: yarn build
+
+      - name: "Validates that TypeScript plugins work"
+        run: |
+          cd ..
+          npm init typescript-playground-plugin playground-my-plugin

packages/create-typescript-playground-plugin/README.md

@@ -9,7 +9,7 @@ A template for creating new plugins for the TypeScript playground.
 <p><b>Step 3</b>: Open the playground in your browser, click "Options" and enable <code>"Connect to localhost:5000"</code></p>
 <p><b>Step 4</b>: Refresh, and see the new tab. That's your plugin up and running</p>
 <p>&nbsp;</p>
-<p>That's all the pieces working in tandem, now you can make changes to the template and build out your plugin. The plugin in dev mode will always become forefront when connected, so you can re-load without a lot off clicks. To understand the template's technology, read the <a href='https://github.com/microsoft/TypeScript-Website/blob/v2/packages/create-playground-plugin/template/CONTRIBUTING.md'>CONTRIBUTING.md</a></p>
+<p>That's all the pieces working in tandem, now you can make changes to the template and build out your plugin. The plugin in dev mode will always become forefront when connected, so you can re-load without a lot off clicks. To understand the template's technology, read the <a href='https://github.com/microsoft/TypeScript-Website/blob/v2/packages/create-typescript-playground-plugin/template/CONTRIBUTING.md'>CONTRIBUTING.md</a></p>
 
 <h2>Alternatives</h2>
 <p>There are community-run templates for Playground plugins which bootstrap your plugin with well-known view libraries:</p>

packages/create-typescript-playground-plugin/index.js

@@ -26,6 +26,7 @@ const install = () => {
     child.on("close", code => {
       if (code !== 0) {
         reject()
+        process.exitCode = 1
         return
       }
       resolve()

packages/create-typescript-playground-plugin/template/package.json

@@ -12,7 +12,7 @@
     "url": "https://github.com/[you]/[repo]"
   },
   "scripts": {
-    "build": "rollup -c rollup.config.js;",
+    "build": "rollup -c rollup.config.js",
     "compile": "tsc",
     "bootstrap": "node scripts/getDTS.js",
     "start": "concurrently -p \"[{name}]\" -n \"ROLLUP,SITE\" -c \"bgBlue.bold,bgMagenta.bold\" \"yarn rollup -c rollup.config.js --watch\" \"yarn serve dist\"",

packages/documentation/copy/en/reference/JSX.md

@@ -133,7 +133,7 @@ function ComponentFoo(prop: FooProp) {
   return <AnotherComponent name={prop.name} />;
 }
 
-const Button = (prop: {value: string}, context: { color: string }) => <button>
+const Button = (prop: {value: string}, context: { color: string }) => <button />
 ```
 
 Because a Function Component is simply a JavaScript function, function overloads may be used here as well:

packages/documentation/copy/en/tutorials/Babel with TypeScript.md

@@ -31,7 +31,7 @@ The downside to using babel is that you don't get type checking during the trans
 
 In addition to that, Babel cannot create `.d.ts` files for your TypeScript which can make it harder to work with your project if it is a library.
 
-To fix these issues, you would probably want to set up a command to type check your project using TSC. This likely means duplicating some of your babel config into a corresponding [`tsconfig.json`](/tconfig) and ensuring these flags are enabled:
+To fix these issues, you would probably want to set up a command to type check your project using TSC. This likely means duplicating some of your babel config into a corresponding [`tsconfig.json`](/tsconfig) and ensuring these flags are enabled:
 
 ```json tsconfig
 "compilerOptions": {