Skip to content

Relate importsNotUsedAsValues -> preserveValueImports #2249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

Relate importsNotUsedAsValues -> preserveValueImports #2249

merged 1 commit into from
May 18, 2023

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Jan 31, 2022

preserveValueImports is already related to importsNotUsedAsValues in the tsconfig reference. Add the reciprocal link, like #1099.

@jablko
Copy link
Contributor Author

jablko commented Feb 1, 2022

I think the CI failure is fixed by microsoft/TypeScript-Website-Localizations#135?

@orta orta mentioned this pull request Feb 3, 2022
Merged
@orta
Copy link
Contributor

orta commented Feb 3, 2022

Agree, looks good to me

@RyanCavanaugh RyanCavanaugh enabled auto-merge April 26, 2023 16:13
jakebailey
jakebailey approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though we should really also add verbatimModuleSyntax. Clearly, this PR is old so I'm not surprised it's not here.

@jakebailey jakebailey closed this May 18, 2023
auto-merge was automatically disabled May 18, 2023 16:43

Pull request was closed

@jakebailey jakebailey reopened this May 18, 2023
@jakebailey jakebailey enabled auto-merge (squash) May 18, 2023 16:43
@jakebailey jakebailey merged commit fe7a95f into microsoft:v2 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jablko @orta @jakebailey