Skip to content

fix: incorrect deprecation link on Advanced Types page of old handbook #3406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

fix: incorrect deprecation link on Advanced Types page of old handbook #3406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/documentation/copy/en/reference/Advanced Types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ title: Advanced Types
layout: docs
permalink: /docs/handbook/advanced-types.html
oneline: Advanced concepts around types in TypeScript
deprecated_by: /docs/handbook/2/types-from-types.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old page covers a ton of different kinds of types, but here you're linking to one very specific concept on a page that's mostly about narrowing and doesn't really serve the same purpose.

deprecated_by: "/docs/handbook/2/narrowing.html#using-type-predicates"

# prettier-ignore
deprecation_redirects: [
Expand Down