Skip to content

Path2D missing string construtor #14660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akarzazi opened this issue Mar 14, 2017 · 4 comments
Closed

Path2D missing string construtor #14660

akarzazi opened this issue Mar 14, 2017 · 4 comments
Assignees
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this

Comments

@akarzazi
Copy link

TypeScript Version: 2.2.1

Code

var p = new Path2D("M10 10 h 80 v 80 h -80 Z");

Expected behavior:
works

Actual behavior:
string is not assignable to Path2D

@mhegazy
Copy link
Contributor

mhegazy commented Mar 15, 2017

@mhegazy
Copy link
Contributor

mhegazy commented Mar 15, 2017

PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes.

@mhegazy mhegazy added this to the Community milestone Mar 15, 2017
@mhegazy mhegazy added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Bug A bug in TypeScript Help Wanted You can do this labels Mar 15, 2017
@can-cc
Copy link

can-cc commented Aug 2, 2017

what?

thw0rted added a commit to thw0rted/TypeScript that referenced this issue Aug 3, 2017
Add `string` constructor for `Path2D` per microsoft#14660.
@thw0rted
Copy link

thw0rted commented Aug 3, 2017

I made the fix on the lib-generator, just need to clear the CLA with my company.

@mhegazy mhegazy modified the milestones: TypeScript 2.6, Community Aug 15, 2017
@mhegazy mhegazy self-assigned this Aug 15, 2017
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.6 Aug 15, 2017
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.8 Mar 9, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 9, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

4 participants