Project does not contain document for @types with TS 2.4

[mjbvz]

From microsoft/vscode#30463

TypeScript Version: 2.4.1

Code

1. Download this project and opened it in vscode: https://github.com/Microsoft/vscode/files/1142617/example.zip
2. Open file1.js and trigger completions.
3. Then open broken.js and try trigger completions

Bug

Trace  - 10:18:13 AM] Response received: completions (24). Request took 2 ms. Success: false . Message: Error processing request. Project '/dev/null/inferredProject1*' does not contain document '/users/matb/library/caches/typescript/2.4/node_modules/parse5/node_modules/@types/node/index.d.ts'
Error: Project '/dev/null/inferredProject1*' does not contain document '/users/matb/library/caches/typescript/2.4/node_modules/parse5/node_modules/@types/node/index.d.ts'
    at Object.ThrowProjectDoesNotContainDocument (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:75718:23)
    at InferredProject.Project.getScriptInfoForNormalizedPath (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:77238:42)
    at InferredProject.Project.getScriptInfo (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:77243:29)
    at ModuleBuilder.AbstractBuilder.getOrCreateFileInfo (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76551:51)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76679:84
    at Object.map (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:1483:29)
    at ModuleBuilder.getReferencedFileInfos (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76679:31)
    at ModuleBuilder.updateFileReferences (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76708:42)
    at ModuleBuilder.ensureProjectDependencyGraphUpToDate (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76693:30)
    at ModuleBuilder.onProjectUpdateGraph (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:76684:22)

[mjbvz]

This issue has also been reported here: microsoft/vscode#30425 (comment)

I need to use TS2.4 to reproduce this due to #17138.
Can reproduce this with just a JS file containing: require("jsdom").

My hypothesis is that this is because parse5 (a dependency of jsdom) has a dependency on @types/node version 6, while the latest version is 8, causing those types to be stored in typescript/2.4/node_modules/parse5/node_modules/@types/node/index.d.ts instead of typescript/2.4/node_modules/@types/node/index.d.ts. Somewhere we must be assuming that the node_modules cache is flat.

Can't reproduce it with just require("parse5"); presumably because we need 2 versions of @types/node in existence to trigger the error.

The error is likely that in getReferencedFileInfos getReferencedFiles to get all referenced files, which for parse5 will include its node_modules/@types. We then call getOrCreateFileInfo, which calls getScriptInfo. getScriptInfo calls getOrCreateScriptInfoForNormalizedPath, but then asserts that the result must already be attached to this project, so it must be expecting to just have gotten an existing scriptInfo and not created one.

[mjbvz]

Thanks for looking into this @Andy-MS!

@rbuckton We're seeing a number of users reporting this in a variety of different cases. Can we please prioritize this for TS 2.4.2

Talked to @sheetalkamat and it looks like this was fixed by #16539.
Now that #17210 is in there should be nothing blocking me from reproducing this in master, but I can't.