Skip to content

Discriminated unions and object literals #18629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thorn0 opened this issue Sep 21, 2017 · 2 comments
Closed

Discriminated unions and object literals #18629

thorn0 opened this issue Sep 21, 2017 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@thorn0
Copy link

thorn0 commented Sep 21, 2017

I'm not sure if it's a bug.

TypeScript Version: 2.4.0 / nightly (2.5.0-dev.201xxxxx)

playground, 2.5.1-insiders.20170825

Code

interface Square {
    kind: "square";
    size: number;
}

interface Rectangle {
    kind: "rectangle";
    width: number;
    height: number;
}
type Shape = Square | Rectangle;

var a: Square = { kind: 'square', size: 100, width: 50 }; // error
var b: Shape = { kind: 'square', size: 100, width: 50 };  // oops

Expected behavior:

Same error. From the kind property, TypeScript should understand that the second object literal is of type Square and prevent us from attaching the width property to it.

Actual behavior:

no error

@mhegazy
Copy link
Contributor

mhegazy commented Sep 21, 2017

Duplicate of #12745

@mhegazy mhegazy marked this as a duplicate of #12745 Sep 21, 2017
@mhegazy mhegazy added the Duplicate An existing issue was already created label Sep 21, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Oct 5, 2017

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.

@mhegazy mhegazy closed this as completed Oct 5, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants