Skip to content

Split ElementTagNameMap and remove it #20134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
falsandtru opened this issue Nov 18, 2017 · 0 comments · Fixed by #20177
Closed

Split ElementTagNameMap and remove it #20134

falsandtru opened this issue Nov 18, 2017 · 0 comments · Fixed by #20177
Assignees
@mhegazy
Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Milestone
TypeScript 2.7

Comments

@falsandtru
Copy link
Contributor

falsandtru commented Nov 18, 2017 •
edited
Loading

Some tag names of HTML and SVG are conflicted. So merging these two is wrong. ElementTagNameMap has to split into HTMLElementTagNameMap and SVGElementTagNameMap.

For example, a tag is defined in both HTML and SVG.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element
https://developer.mozilla.org/en-US/docs/Web/SVG/Element

So the result type of document.querySelector('a') is defined as HTMLAnchorElement by TypeScript, but the actual type is HTMLAnchorElement | SVGAElement.

related: #14783
@falsandtru falsandtru changed the title Split ElementTagNameMap and remove it after Split ElementTagNameMap and remove it Nov 18, 2017
@mhegazy mhegazy added the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Nov 21, 2017
@mhegazy mhegazy self-assigned this Nov 21, 2017
@mhegazy mhegazy added the Suggestion An idea for TypeScript label Nov 21, 2017
@mhegazy mhegazy added this to the TypeScript 2.7 milestone Nov 21, 2017
@mhegazy mhegazy added the Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript label Nov 21, 2017
@mhegazy mhegazy mentioned this issue Nov 21, 2017
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Nov 21, 2017
@mhegazy mhegazy removed the Fixed in TSJS repo Fix merged in https://github.com/Microsoft/TSJS-lib-generator, but not ported yet label Nov 21, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Fixed A PR has been merged for this issue Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 2.7
Development

Successfully merging a pull request may close this issue.

Port generated lib files microsoft/TypeScript
2 participants
@falsandtru @mhegazy