Skip to content

Quickfix for @ts-ignore doesn´t respect formatting #21355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
egamma opened this issue Jan 23, 2018 · 0 comments
Closed

Quickfix for @ts-ignore doesn´t respect formatting #21355

egamma opened this issue Jan 23, 2018 · 0 comments
Assignees
@mhegazy
Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue
Milestone
TypeScript 2.8

Comments

@egamma
Copy link
Member

egamma commented Jan 23, 2018

In this setup:
image

Apply the quick fix to ignore the error message
image

This results in
image

I would have expected:
image
@mhegazy mhegazy added Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. labels Jan 30, 2018
@mhegazy mhegazy assigned ghost Jan 30, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Jan 30, 2018
@mhegazy mhegazy assigned mhegazy and unassigned ghost Mar 5, 2018
mhegazy added a commit that referenced this issue Mar 5, 2018
@mhegazy
Fix #21355: Format // @ts-ignore added by quick fix
2e5bf36
@mhegazy mhegazy mentioned this issue Mar 5, 2018
Merged
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 5, 2018
mhegazy added a commit that referenced this issue Mar 6, 2018
@mhegazy
Fix ignore message indentation (#22340)
b2dd610 
* Update baselines for user tests

* Add explicit indentation

* Fix #21355: Format `// @ts-ignore` added by quick fix

* Extract check to a separate function

* Consolidate checking for valid insert location

* Code review comments

* Do not return makeChange
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mhegazy mhegazy

Labels
Bug A bug in TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.8
Development

No branches or pull requests
2 participants
@egamma @mhegazy