Auto imports showing imports from `../../node_modules/@types`

[mjbvz]

Manually moving microsoft/vscode#47005 to TS Repo to continue investigation

@techsin reports that they are seeing auto import suggestions for paths such as ../../../node_modules/@types. They are using TypeScript 2.7.2 and have a jsconfig.json with proper excludes configured.

Here's the TS Server log: tsserver.log

[yortus]

This is how node.js module lookup works, and there are workflows that rely on the current lookup behaviour. For example monorepos using tools like lerna will have their node modules at the monorepo root, which may be several directories up from the package.json of packages declaring the dependencies.

[techsin]

@yortus one should be able to disable lookup beyond root directory using jsconfig.json at least. Otherwise, autosuggest feature becomes a obstacle. It causes random auto imports, which you might not be aware of if you were working at line 80.

[yortus]

@techsin I just noticed that this had been labeled as a bug and wanted to point out that the current behaviour is not a bug. An option sounds appropriate.

[techsin]

there is an option in jsconfig / tsconfig that tells what to exclude, but despite telling it to exclude node_modules, it doesn't. Not the one in project root, or above in user directory. Thus the bug.

{
	"compilerOptions": {
		"target": "es6"
	},
	"exclude": [
		"node_modules", <--- no effect
		"../../node_modules", <--- no effect
		"**/node_modules/*" <--- no effect
	]
}

[yortus]

Ok, got it now. The issue title makes it look like the lookup behaviour is the problem, but it's actually the exclude behaviour. I should have read the original issue, sorry!

[techsin]

No, Problem. I just want it fixed, more than 10 times, I've pressed tab thinking it'd do something I want and end up importing random stuff which doesn't go away with 1 ctrl+z. So you have to delete whatever it expanded to and delete the line at top that says import {InksljdEjlkdjksl} from "../../../AppData/Microsoft/Typescript/node_modules/Something/@types/something/something"

kind makes you never use autocomplete again.

So glad there is built in git diff, so you can actually view one last time all things that are going to be changed.

@techsin I'm having trouble reproducing this with typescript@next. I get import completions for foo and not for ../node_modules/foo. Try doing npm install -g typescript@next and pointing vscode to it (instructions). If it's still happening, could you try to get a sample project that reproduces the error that you could share?

[techsin]

https://github.com/techsin/vscodeAutoCompleteBug

interestingly, through process of elimination, i was able to nail it down to pug package. but i dont know how pug package would cause to override jsconfing.json

[techsin]