Typescript Language service not finding symbolic linked (junction) npm module

[kunlongxu]

TypeScript Version: 2.8.1
OS Version: macOS 10.13.3
vscode: 1.22.1

Search Terms: npm link

Code

1. A symbolic link (NTFS junction) to a library package in node_modules breaks code's intellisense ability to find the module, even though building from the command line works fine. This makes node dev a pain when developing a lib and consuming package and don't want to go through the publish / install loop

{
    "compilerOptions": {
        "module": "commonjs",
        "moduleResolution": "node",
        "sourceMap": true,
        "declaration": true,
        "rootDir": "src", 
        "outDir": "lib",
        "target": "es2015",
        "lib": [
            "dom",
            "es2016"
        ],
        "noImplicitAny": false
    },
  "include": [
    "src/**/*"
  ]
}

2. Create and compile another package consumer with a file that references the lib with an import {foo} from 'lib'

3. Copy the lib into the consumer's node_modules - as if it had been `npm install'ed

4. Look at the import line in code - all intellisense is good. lib is found

5. Delete node_modules\lib

6. Either manually link by adding a junction or use npm link ..\lib lib is navigable in the code file browser (on left)

7. Look at the import line in code - 'lib' has red squiggle and hover displays '[ts] Cannot find module 'lib'.'

I can supply all files if required, but the lib is just a single file with a single export and consuming code references it. basic stuff.

Expected behavior:
ts-server can find npm link module
Actual behavior:
ts-server can not find npm link module
Playground Link:

Related Issues: microsoft/vscode#25312

[kunlongxu]

@RyanCavanaugh

[sheetalkamat]

@linmodev can you share the tsserver and ti log with the issue.

1. In VS Code: "typescript.tsserver.log": "verbose"
   If possible can you also use typescript@next. (using nightly build in vscode)
2. Restart vscode and reproduce the issue
3. In VS Code, run the TypeScript: Open TS Server log command, Opened folder will have two files showing the type installer and tsserver log, share those two files.

[kunlongxu]

The log file is too long. I save it in my github gist.
https://gist.github.com/linmodev/fbae4b4ed09d194c72e11164b6e300de
https://gist.github.com/linmodev/0425b2bd67b2e9c178b0cc70043937eb

[kunlongxu]

@sheetalkamat I update my ts version to 2.9.0-dev.20180418. The problem still exsit .

[sheetalkamat]

@linmodev Thank you for the logs. I took a look at it and were able to tell much from the logs.
From your log it looks like you are not using typescript@next ( log link)
Also you do not have tsconfig.json and that means it will use inferred project with following options:

{"module":"commonjs","target":"es2016","jsx":"preserve","allowJs":true,"allowSyntheticDefaultImports":true,"allowNonTsExtensions":true}

Do you have tsconfig.json somewhere? Since you opened folder in vscode at /Users/xukunlong/Desktop/study-project/projectA thats the location tsconfig.json would be looked up till.
I couldnt tell much from the logs whats going on. Can you please add tsconfig.json in that folder and add traceResolution: true in your compiler options and get the log. That should indicate what are the location looked up and if and how the module resolution went wrong. Also please share the repro code and steps you took to create the folder structure. (It could be os dependent and hence asking for the log apart from the repro code and exact steps)

[kunlongxu]

@sheetalkamat
This is just a demo project, so I forget add tsconfig file. It has no effect or response when add this file.

The picture of above o shows the structure.
I upgraded ts according to your requirements and added tsconfig.
The below is new log.
https://gist.github.com/linmodev/9c18d5c2e6225c4d4f21af1c5f483056
https://gist.github.com/linmodev/df91ead87b517f39044176df9f9b8539

[sheetalkamat]

@mjbvz I looked at the tsserver log and it seems like there are two open requests for the same file? (first open, second open) That breaks the asserts we have. Can you see what went wrong and why there are two open requests for same file /Users/xukunlong/Desktop/study-project/projectA/example/index.ts

[mjbvz]

@sheetalkamat I couldn't repo the issue but looking over the code, I identified one way the two open requests could happen: microsoft/vscode@55a10f7

Should be in the VS Code 1.24 insiders builds once those resume later this week. Let me know if you have reliable repo steps for this

[sheetalkamat]

@mjbvz I dont have repro but only the tsserver log shared by @linmodev