getEditsForFileRename converts imports to relative paths

[mjbvz]

From microsoft/vscode#52630

TypeScript Version: 3.0.0-dev.20180619

Search Terms:

• getEditsForFileRename
• imports

Code
For a TS project:

tsconfig.json

{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es2016",
        "jsx": "preserve",
        "baseUrl": ".",
    },
    "exclude": [
        "node_modules",
        "**/node_modules/*"
    ]
}

sub/a.ts

export const a = 1;

sub/index.ts:

import { a } from 'sub/a';
console.log(a);

1. In VS Code, rename sub/index.ts to sub/index2.ts
2. Select option to update imports

Expected behavior:
No edits returned from getEditsForFileRename in this case

Actual behavior:
Edits returned from getEditsForFileRename convert sub/index.tsto use relative paths:

import { a } from './a';
console.log(a);

Related Issues:

• getEditsForFileRename: changes package import of symlinked package to relative path #25029

[arackaf]

@mjbvz - I see this case is marked as closed / fixed, but the behavior persists in VS Code version 1.25.1, which Code tells me is up to date - I'm running TS 2.9.2.

Did this fix just not make it into the July releases of Code?

[mjbvz]

It’s fixed in vscode insiders (which uses Ts 3)

[arackaf]

Ah gotcha - look forward to that - thanks!