Skip to content

Rename JSX element should rename open and closing tag only #25133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhegazy opened this issue Jun 21, 2018 · 0 comments
Closed

Rename JSX element should rename open and closing tag only #25133

mhegazy opened this issue Jun 21, 2018 · 0 comments
Labels
Bug A bug in TypeScript Domain: JSX/TSX Relates to the JSX parser and emitter Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Jun 21, 2018

TypeScript Version: 3.0.0-dev.201xxxxx

Search Terms:

Code

var x = <div></div>; // rename div in open element to span
var y = <div></div>;

Expected behavior:

var x = <span></span>; 
var y = <div></div>;

Actual behavior:

var x = <div></div>; 
var y = <div></div>;

Playground Link:

Related Issues:

It is worth nothing that Occurrences highlight open and closed elements for JSX but not rename.

Find all references should not change though. there is value in finding all div elements in the code base.

@mhegazy mhegazy added Bug A bug in TypeScript Domain: JSX/TSX Relates to the JSX parser and emitter labels Jun 21, 2018
@mhegazy mhegazy assigned ghost Jun 21, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 21, 2018
@ghost ghost closed this as completed in #25273 Jun 27, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jun 28, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: JSX/TSX Relates to the JSX parser and emitter Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

1 participant