Debug Failure. False expression: Expected isNewFile for (only) new files

[amcasey]

We have occurrences from 3.0.0-dev to 3.2.0-dev. Here's a stack from 3.1.3:

Error processing request. Debug Failure. False expression: Expected isNewFile for (only) new files
Verbose Debug Information: {"isNewFile":false,"hasScriptInfo":false}
Error: Debug Failure. False expression: Expected isNewFile for (only) new files
Verbose Debug Information: {"isNewFile":false,"hasScriptInfo":false}
    at mapTextChangesToCodeEdits (tsserver.js:123151:22)
    at IOSession.Session.mapTextChangeToCodeEdit (tsserver.js:122984:24)
    at tsserver.js:122981:73
    at Array.map (<anonymous>)
    at IOSession.Session.mapTextChangesToCodeEdits (tsserver.js:122981:36)
    at IOSession.Session.mapCodeFixAction (tsserver.js:122977:84)
    at tsserver.js:122930:96
    at Array.map (<anonymous>)
    at IOSession.Session.getCodeFixes (tsserver.js:122930:55)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (tsserver.js:121789:61)
    at tsserver.js:123086:88
    at IOSession.Session.executeWithRequestId (tsserver.js:123077:28)
    at IOSession.Session.executeCommand (tsserver.js:123086:33)
    at IOSession.Session.onMessage (tsserver.js:123106:35)
    at Interface.<anonymous> (tsserver.js:124369:27)
    at emitOne (events.js:116:13)
    at Interface.emit (events.js:211:7)
    at Interface._onLine (readline.js:282:10)
    at Interface._normalWrite (readline.js:424:12)
    at Socket.ondata (readline.js:141:10)
    at emitOne (events.js:116:13)
    at Socket.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at Socket.Readable.push (_stream_readable.js:208:10)
    at Pipe.onread (net.js:594:20)

Is that the wrong stack trace? The diagnostic "Expected isNewFile for (only) new files" should only happen in mapTextChangesToCodeEdits, not tryResuseStructureFromOldProgram.

[amcasey]

Quite possibly - I've been looking at several. Let me confirm.

[amcasey]

Fixed - sorry about that.

[Hexcles]

I'm seeing this error from tsserver in my editor (Vim with YCM) (with almost the same stacktrace) when I have import fs = require('fs'); style import in my Node project (target=es2017, everything else is the default). Switching to const fs = require('fs') makes the error go away.

[Hexcles]

I just found out it only happened when I used import = require style import on a module without type annotations, but this still looks like a bug -- it shouldn't crash the server. tsc is still able to tell me to try npm install @types/..., among other errors.

@Hexcles I'm not able to reproduce this crash using that repro in typescript@next. I'm testing in a directory that consists of just these files:
a.ts:

import fs = require('fs');

tsconfig.json:

{
    "compilerOptions": {
        "target": "es2017"
    }
}

I've also tested with @types/node installed but still didn't see a crash.
I assume you're also seeing a diagnostic Import assignment cannot be used when targeting ECMAScript modules. given those compiler options.