Improve exception reporting

[EvgenyMuryshkin]

Search Terms

Crash, Maximum call stack size exceeded, fork-ts-checker-webpack-plugin

Suggestion

Improve crash logs by dumping statements, file names, line number and everything that might help to identify faulty statement.

I just upgraded packages and toolchain for large rect\typescript project.
I am using webpack with fork-ts-checker-webpack-plugin for type checks.

Plugin works fine with 3.1.6 and crashing with 3.2.2. Does not work with 3.3.0-dev.20181220 as well.

I found that dev version 3.2.0-dev.20181030 works ok, and 3.2.0-dev.20181031 is crashing.

Here is a crash log

RangeError: Maximum call stack size exceeded
    at resolveNameHelper (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31504:35)
    at resolveName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31502:20)
    at resolveEntityName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:32353:26)
    at resolveTypeReferenceName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:38055:20)
    at getTypeFromTypeReference (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:38240:30)
    at getTypeFromTypeNode (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:39667:28)
    at getConstraintFromTypeParameter (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:37898:72)
    at fillMissingTypeArguments (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:37447:33)
    at getTypeFromClassOrInterfaceReference (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:37999:78)

Use Cases

It is rather impossible to identify faulty statements manually. I cannot distill what exactly is causing that, so detailed exception logging would be very helpfull

Examples

[Exception evaluating c:/code/example.tsx ]
[class: ABC]
[method: func()]
[expression: a = b + c; ]

RangeError: Maximum call stack size exceeded
at resolveNameHelper (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31504:35)
at resolveName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31502:20)

Checklist

My suggestion meets these guidelines:

• This wouldn't be a breaking change in existing TypeScript/JavaScript code
• This wouldn't change the runtime behavior of existing JavaScript code
• This could be implemented without emitting different JS based on the types of the expressions
• This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
• This feature would agree with the rest of TypeScript's Design Goals.

[j-oliveras]

The callstack seems the same as #28873 (see second post).

The crashes caused be assertion violations can be possible to make something like proposed, but on exceptions like Maximum call stack size exceeded (and any other javascript runtime exception) you has no control about it.

[EvgenyMuryshkin]

The callstack seems the same as #28873 (see second post).

The crashes caused be assertion violations can be possible to make something like proposed, but on exceptions like Maximum call stack size exceeded (and any other javascript runtime exception) you has no control about it.

I did a quick fix, it does not crash in my case, please review and apply if it did not break anything else

EvgenyMuryshkin@9f88c2f

Thanks