Missing references in some cases

[OliverJAsh]

TypeScript Version: 3.5.2

Search Terms:

Code

We have some code that looks like this:

./main.ts:

import { types } from './types';

type Test = types.Foo;

./types/index.ts:

import * as types from './types';
export { types };

./types/types.ts:

export type Foo = 1;

When I try to find references for Foo, I'm getting no results. "Go to definition" does still work.

However, I can only reproduce this behaviour in our large TS project. I've tried and failed to create a reduced test case. If I start removing files from our large TS project, it will eventually begin to work, suggesting there's some sort of (memory?) threshold which we could be crossing.

Here is a video recording to demonstrate this: https://www.dropbox.com/s/xw7c3lk0mxhr5vj/Screen%20Recording%202019-08-21%20at%2021.40.59.mov?dl=0

I have also attached a TS server log, which was recorded at the same time as the above video.

Any ideas what could be going on here? What's the best way for me to debug this?

tsserver.log

[sheetalkamat]

Can you please share the screen recording and tsserverlog again. (The screen share link is not working so I cant figure out what you expect and what is happening.)

[OliverJAsh]

Sorry about that @sheetalkamat. I won't delete the video this time around. 🤦‍♂

tsserver.log

Video

[OliverJAsh]

Just found another bug which might be related: #33489

[sheetalkamat]

@OliverJAsh From the log it looks like when finding references its hitting the assertion. We would need code sample to investigate so please provide small repro if you can or you can share your source code. We can get NDA for getting the repro project if you need to. Thanks.

[OliverJAsh]

I would be happy to share my code, it's in a private GitHub repository. I guess I'll need an email address from you, for me to add to it? I tried creating a reduced test case but it was too difficult unfortunately.

…

On Mon, 30 Sep 2019, 18:17 Sheetal Nandi, ***@***.***> wrote: @OliverJAsh <https://github.com/OliverJAsh> From the log it looks like when finding references its hitting the assertion. We would need code sample to investigate so please provide small repro if you can or you can share your source code. We can get NDA for getting the repro project if you need to. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33017?email_source=notifications&email_token=AAHBACIEYJ67YPJGW6ND5ZTQMIYCDA5CNFSM4IOOFC7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76MP5Y#issuecomment-536659959>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHBACM3GF66HDG2646LQNLQMIYCDANCNFSM4IOOFC7A> .

[sheetalkamat]

email is shkamat at microsoft dot com

[OliverJAsh]

Hi @sheetalkamat, I have sent an NDA to you and @DanielRosenwasser.

[OliverJAsh]

@sheetalkamat I have sent you an invite to access the repo.

To test this issue, the file I used in my video is located at app/routes/Explore/LandingPage/components/PopularCategories/PopularCategories-helpers.ts.

[OliverJAsh]

@sheetalkamat Sorry I forgot to mention, this is on the maintenance/named-namespace-imports-landing-pages branch.

[sheetalkamat]

@OliverJAsh Thank you for providing details. I was able to repro this and will look into this soon.