Skip to content

arguments as object literal field name emitted as arguments_1 when target es5 #33540

Closed
@plantain-00

Description

@plantain-00

TypeScript Version: 3.6.3

Search Terms:
arguments, arguments_1

Code

// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
function parseMemberOrCallExpression(tokens: (Token | Expression)[]) {
    const newTokens: (Token | Expression)[] = []
    let expectCall = false
    for (let i = 0; i < tokens.length; i++) {
      const token = tokens[i]
      if (token.type === 'PunctuatorToken') {
        if (!expectCall && token.value === '?.') {
          expectCall = true
          continue
        }
        if (expectCall && token.value !== '[' && token.value !== '(') {
          throw new Error(replaceLocaleParameters(this.locale.unexpectToken, token.range[0], token.range[1]))
        }
        if (callOperators.includes(token.value)) {
          const object = newTokens.pop()!
          newTokens.push(this.parseExpression([object, token, tokens[i + 1]], getHeadTailRange(object, tokens[i + 1])))
          i++
        } else if (token.value === '[') {
          const index = this.findGroupEnd(tokens, i, token.value)
          const object = newTokens.pop()!
          const groupedTokens = tokens.filter((_, j) => j > i && j < index)
          const property = this.parseExpression(groupedTokens, getTokensRange(groupedTokens))
          const memberExpression: MemberExpression = {
            type: 'MemberExpression',
            object: this.parseTokenOrExpression(object),
            property: this.parseTokenOrExpression(property),
            range: [object.range[0], tokens[index].range[1]]
          }
          if (expectCall) {
            memberExpression.optional = true
          }
          newTokens.push(memberExpression)
          i = index
        } else if (token.value === '(') {
          const index = this.findGroupEnd(tokens, i, token.value)
          const argumentsExpressions = this.parseItems(tokens, i, index)
          const lastToken = newTokens.pop()!
          const callExpression: CallExpression = {
            type: 'CallExpression',
            callee: this.parseExpression([lastToken], lastToken.range),
            arguments: argumentsExpressions,
            range: [lastToken.range[0], tokens[index].range[1]]
          }
          if (expectCall) {
            callExpression.optional = true
          }
          newTokens.push(callExpression)
          i = index
        } else {
          newTokens.push(token)
        }
      } else {
        newTokens.push(token)
      }
    }
    return this.parseExpression(newTokens, getTokensRange(newTokens))
  }

Expected behavior:

var callExpression = {
                    type: 'CallExpression',
                    callee: this_1.parseExpression([lastToken], lastToken.range),
                    arguments: argumentsExpressions,
                    range: [lastToken.range[0], tokens[index].range[1]]
                };

Actual behavior:

var callExpression = {
                    type: 'CallExpression',
                    callee: this_1.parseExpression([lastToken], lastToken.range),
                    arguments_1: argumentsExpressions,
                    range: [lastToken.range[0], tokens[index].range[1]]
                };

Playground Link:
http://www.typescriptlang.org/play/index.html?target=1#code/GYVwdgxgLglg9mABABwIYCcDOBTAstgWwCNt0B5dAYVQBsaBRAD2XW003jAAoo4BrbGEwAuRFwAq-QYgA+iJizYcEASgDaAXRWIA3gChEhxBASYoiMNgDukgUNESpSOQtbtO6jYgC8iTQaMabHNsZmxoajofRGBaHADDYDh0MSDzGGiABgBuRAyAHkReO0wAOiCwAHMoAAtcmABqBu19IyMTIXNi6V9uoTUYDQSjGGAxPtKoAE9kbB9vXwByAAVwaBBUXnRbQUWW4bbRsQBCUNmI2hpEADJroqdSgDdaEDmFpYB+Ur3dA7bEM7hKCRK69dCvP5tDqwMAQ-5GAC+kLyYy4gIuUVu9zsTxec2OC0QizUixudwmzxor0QBKWXB+rXhRlq6DgVgs1nk6FZ6C4rGQNFQEGwABk4BBaNhlhhUARgqRMDwajAyjRxZLSuB0VAdmAADTYwSldCoKrYNSZDQGiYms1qACMWhUyKRTJRYgldDIsxNWzKMEgVIAJmweA9Ka8VPs3YYOmZEHAiAArIHRSw2JxlZBwZBcFTHZGGdO6rMgTA1JUq0poLDYVxKThcNSJlPQa1OdslAaIBqIR1WxCVYIACWwqCD4lQMBoACVTUOuC2gZ3BJhu73HVHnTG8k0XQCaDh3WGcRG3oTiQzC8ZTOkwCHGNFalXgAGgwBxVkgZD0e8n1cGjAK5gLiVLYNuMZxuYS7QGm1gltWOZ5gWO5QYOX6zBOmZPpmpSvjQUCkFwXAAPoGkm2jeAAfIgSaIDRGRYnRhRvqEEFumhLA5qQ0xPsqWYYDg9buAgXCVBh2BYSUBpDjqmZzmaYkSVJq5RteaFysQpDCcoYCiPgWnoDpnDRIyO7TLMoiLAZJBGcwbi6YserXoYMFQKIz4CbWuoUMZoluSozk7oYXE+tMHn8dWgnYD5dmKCJ3ChTxUyBS5iC2kOojNsmQLGvO5qWsBa6sYwGh5Xa-bXq6MZHGiYQYjQ0bBZptl+SBOawAgtBPuC2BVdexa4cgZYVi12n2Q2qjXhkvglfu2CHnMtUUni8x0leqG3nk96hHxL5vp+cDfr+Qb-kIgHAaBkbqVtGCVCAcpgFAmBtZge1eTgACShEEIqfSYBd20PuxTJoYKZi6nBGYlIhub5jdnTGJcbWiCCbWmWlFnYFZaMTQlTlpZ6QTY0UkU1kJeO6U24NyXYA407q5VDqlwWIHdD2CM9ojs49z2vUFwUZSTagMw8QsWgO-0DDtpVM+alU7tVbq1dqIJNahyOU5wpQdZw3VgnCMZK0yg0w8N5ZcETbUg-CM1A6E82Lb8O6m6u1YjWdNuIn8CIHkeZn-K7QjuxbfRe8bxusFAIDoEgnlRbWbVcEHAODsEJYKQuKdqYYCJAA

Related Issues:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions