Skip to content

In 3.7, there is no way to override get/set declaration emit for accessors #33640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
weswigham opened this issue Sep 27, 2019 · 2 comments
Closed
Assignees
Labels
Declined The issue was declined as something which matches the TypeScript vision

Comments

@weswigham
Copy link
Member

This is troublesome for producing declaration files that are compatible with versions of typescript less than 3.6. Most other emit changes you can override by writing an explicit type annotation, however there's no equivalent for changing getter/setter declaration emit. This comes up in our docker suite, as the get/set declaration emit breaks azure-sdk, as they test their declaration files against older versions of TS.

@bterlson
Copy link
Member

@weswigham can you tell me more about the typings that are breaking here?

@weswigham
Copy link
Member Author

When you have accessors in a class we now emit accessors in the corresponding declaration file. TS 3.6 supports this, but older versions of TS do not.

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label Oct 14, 2019
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.7.1 milestone Oct 14, 2019
@weswigham weswigham added Declined The issue was declined as something which matches the TypeScript vision and removed Needs Investigation This issue needs a team member to investigate its status. labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Declined The issue was declined as something which matches the TypeScript vision
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants