Skip to content

Add legacyAccessorDeclarations flag #34724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weswigham
Copy link
Member

Fixes #33640

This allows users of TS 3.7 and accessors to generate declaration files which can be consumed by TS 3.5 and below.

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided not to do this after the team discussed it and I talked to @bterlson on the Azure SDK team. Instead I wrote https://github.com/sandersn/downlevel-dts and I believe the Azure SDK team are planning to publish a typesVersions folder for 3.3-3.5.

@weswigham
Copy link
Member Author

(ノಠ益ಠ)ノ彡┻━┻ WTB close of associated issue in future so work isn't duplicated T.T

@weswigham weswigham closed this Oct 25, 2019
@sandersn
Copy link
Member

Oops. Sorry, didn't know about that issue. FWIW I had a PR for this too: #33880

@sandersn
Copy link
Member

So: triplicated I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In 3.7, there is no way to override get/set declaration emit for accessors
2 participants