-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Add option to disable TS using inline import types in quick fixes #35078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Duplicate of #34995 |
In #32910, @DanielRosenwasser said
In that fix, we didn’t discuss adding an option, we just made it always do an import declaration. @mjbvz do people really want an option, or does it seem like most people just want the import declaration? It should also be noted that #35200 could have an impact on this discussion, so we may want to wait and see where it lands, particularly on whether the default behavior of the compiler’s elision of imports used only in type positions is going to change. |
@andrewbranch Yes I think VS Code would prefer that imports always be added at the top of the file. I'm not sure if other users prefer inline imports however, which is why I proposed having a setting to control this. We should try getting actual user feedback on this Also 👍 for #35200 |
@mjbvz @DanielRosenwasser: with type-only imports in master, the discussion at #36038, and #36412 looking likely to be merged, what’s the latest feeling on the right thing to do here? On one hand, auto-imports will not use |
For VS Code, we would prefer adding regular imports. I agree though that this should not introduce an error, so observing |
TypeScript Version: 3.8.0-dev.20191112
Search Terms:
Code
For a small project:
iface.ts
index.ts
implement interface
onFoo
Current Behavior:
The generated code is:
Request
We would like an option to tell TypeScript to not use inline imports and instead always add normal imports at the top of the file.
/cc @bpasero Since I know you were passionate about this issue
The text was updated successfully, but these errors were encountered: