Skip to content

Ensure find-all-refs works on unresolved locals #38836

Open
@DanielRosenwasser

Description

@DanielRosenwasser

Spoke with @amcasey about this one.

Given the following

blah.yadda.yadda

blah will be an unresolved and should be an error, but we still want find-all-references on this symbol to work reasonably well. This is especially important in the mode described in #37713, where TypeScript won't have access to symbols in the global scope.

This can potentially be achieved by creating an "error scope" whose symbol table contents are progressively populated every time resolution fails.

Activity

sheetalkamat

sheetalkamat commented on Jul 24, 2020

@sheetalkamat
Member

Another option is to use results of navTo when symbol is not resolved instead of changing symbol tables?

added
RescheduledThis issue was previously scheduled to an earlier milestone
on Aug 31, 2020
removed this from the TypeScript 4.1.0 milestone on Dec 11, 2020

16 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Domain: Symbol NavigationRelates to go-to-definition, find-all-references, highlighting/occurrences.Experimentation NeededSomeone needs to try this out to see what happensIn DiscussionNot yet reached consensusRescheduledThis issue was previously scheduled to an earlier milestoneSuggestionAn idea for TypeScript

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @DanielRosenwasser@andrewbranch@ahejlsberg@RyanCavanaugh@sheetalkamat

      Issue actions

        Ensure find-all-refs works on unresolved locals · Issue #38836 · microsoft/TypeScript