Skip to content

IOSession class is accessing this before calling super #40399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Jack-Works opened this issue Sep 6, 2020 · 0 comments · Fixed by #40645
Closed

IOSession class is accessing this before calling super #40399

Jack-Works opened this issue Sep 6, 2020 · 0 comments · Fixed by #40645
Labels
Bug A bug in TypeScript
Milestone
Backlog

Comments

@Jack-Works
Copy link
Contributor

TypeScript Version: master branch

I changed TypeScript build target from "ES5" to "ES2019" and it failed to start.

 if (this.constructed) {
                    ^

ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor

image
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Sep 9, 2020
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Sep 9, 2020
Jack-Works added a commit to Jack-Works/TypeScript that referenced this issue Sep 19, 2020
@Jack-Works
fix: IOSession access this before calling super
7e96df9 
close microsoft#40399 

This makes the TS server crashes if the build target is ES6 or higher.
@Jack-Works Jack-Works mentioned this issue Sep 19, 2020
Merged
Jack-Works added a commit to Jack-Works/TypeScript that referenced this issue Oct 15, 2020
@Jack-Works
fix: IOSession access this before calling super
1cf58c3 
close microsoft#40399 

This makes the TS server crashes if the build target is ES6 or higher.
sheetalkamat pushed a commit that referenced this issue Oct 15, 2020
@Jack-Works
fix: IOSession access this before calling super (#40645)
ad96a52 
* fix: IOSession access this before calling super

close #40399 

This makes the TS server crashes if the build target is ES6 or higher.

* fix

* revert unrelated changes

* revert unrelated changes

* revert unrelated changes

* better way
@Jack-Works Jack-Works mentioned this issue Mar 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: IOSession access this before calling super Jack-Works/TypeScript
2 participants
@Jack-Works @RyanCavanaugh