-
Notifications
You must be signed in to change notification settings - Fork 12.8k
importModuleSpecifierEnding = js doesn't apply for autocomplete within import paths #44374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you have
? |
No I don't set that, I can't actually remember why I ended up needing to use .js imports but at some point this not having it was causing exceptions due to some bundling problem. I just tried to remove and it seemed to work, I'm a little hesitant to change it when it working though. But why would you need |
Importing a That is, if you have // file: myLib.js
export const myConst = 1; and type the following in a myConst You should not be offered a completion at all. If you enable What I think is a bug, is that we complete with the cc @andrewbranch as I'm not super familiar with how module resolution works. Edit: after more investigation I see that auto import completion (not import string completion) adds the |
I can't remember the exact reason but using .js fixed a compile/bundling issue for me at some point. I use tsc and then webpack on its output, could be related to workers, dynamic imports or es modules. |
Auto imports are working correctly and these path completions are working incorrectly. You’re never allowed to write |
Bug Report
I have this workspace setting which works great for auto import:
But when auto completing the path it still does .ts which requires manually changing:
🔎 Search Terms
importModuleSpecifierEnding
🕗 Version & Regression Information
4.3.0-dev.20210503
The text was updated successfully, but these errors were encountered: