Skip to content

noEmitOnError slows down incremental per file emit #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
basarat opened this issue Sep 21, 2015 · 1 comment
Closed

noEmitOnError slows down incremental per file emit #4894

basarat opened this issue Sep 21, 2015 · 1 comment
Labels
By Design Deprecated - use "Working as Intended" or "Design Limitation" instead

Comments

@basarat
Copy link
Contributor

basarat commented Sep 21, 2015

This might be by design. I'm creating this issue purely for clarity 🌹

Basically services.getEmitOutput(filePath); goes from under 10ms to over 1.5seconds probably because it seems to validate the whole project. So we can't do a file by file emit.

First reported by @robertknight here : TypeStrong/atom-typescript#590

@mhegazy
Copy link
Contributor

mhegazy commented Sep 21, 2015

yup. that is by design. when you have noEmitOnError, you are asking the compiler not to emit any files if there is any error in your project. to do this the compiler needs to check all files do not have errors, which is in fact the majority of the time for emit.

i would suggest not setting the flag if you are doing incremental builds.

@mhegazy mhegazy added the By Design Deprecated - use "Working as Intended" or "Design Limitation" instead label Sep 21, 2015
@mhegazy mhegazy closed this as completed Sep 21, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
By Design Deprecated - use "Working as Intended" or "Design Limitation" instead
Projects
None yet
Development

No branches or pull requests

2 participants