TS Server stats files outside of project root when looking up modules

[mjbvz]

Related to #52695

Bug Report

🔎 Search Terms

• fs.stat
• statSync
• performance

Problem

While working on web project wide IntelliSense, I noticed that TS would try stating files outside of the current project root. Here's a trace of some fs.statSync on desktop. In this case the folder I have open is /Users/matb/projects/san/

/Users/matb/projects/san/node_modules/@nestjs/common
/Users/matb/projects/node_modules/@nestjs/common
/Users/matb/node_modules/@nestjs/common
/Users/node_modules/@nestjs/common
/node_modules/@nestjs/common
/Users/matb/projects/san/node_modules/@types/@nestjs/common
/Users/matb/projects/node_modules/@types/@nestjs/common
/Users/matb/node_modules/@types/@nestjs/common
/Users/node_modules/@types/@nestjs/common
/node_modules/@types/@nestjs/common
...

I know this is how node tries resolving packages, but is this something we could avoid? When opening files, we pass in a projectRootPath that I believe is intended to prevent TS from opening files outside of the workspace

These calls are relatively fast on desktop but can be very slow on web as they hit the network. I had to add some extra logic to our virtual file system to avoid making these requests

[sheetalkamat]

Is this same as #52702

[fatcerberus]

Yes, this issue is the same as #52702… because that’s this issue 😉

[sandersn]

Probably #52637

[sheetalkamat]

Thanks @sandersn thats what i meant to paste but copied from wrong tab...

[typescript-bot]

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.