[NewErrors] 5.1.0-dev.20230306 vs 5.0.1-rc #53122

typescript-bot · 2023-03-06T23:49:42Z

The following errors were reported by 5.1.0-dev.20230306, but not by 5.0.1-rc
Pipeline that generated this bug
Logs for the pipeline run
File that generated the pipeline

This run considered 250 popular TS repos from GH (after skipping the top 0).

Successfully analyzed 131 of 250 visited repos

Outcome	Count
Detected interesting changes	7
Detected no interesting changes	124
Git clone failed	1
Package install failed	25
Project-graph error in old TS	5
Too many errors in old TS	83
Unknown failure	5

Investigation Status

Repo	Errors	Outcome
angular/angular-cli	6
compiler-explorer/compiler-explorer	2
infinitered/ignite	1
Molunerfinn/PicGo	3
pmndrs/jotai	1
tldraw/tldraw	14
trufflesuite/truffle	6

typescript-bot · 2023-03-06T23:49:43Z

angular/angular-cli

7 of 19 projects failed to build with the old tsc and were ignored

packages/angular_devkit/build_angular/test/hello-world-app/e2e/tsconfig.e2e.json

error TS2688: Cannot find type definition file for 'jasmine'.
- Project Scope
error TS2688: Cannot find type definition file for 'node'.
- Project Scope

packages/angular_devkit/build_angular/test/hello-world-app/src/tsconfig.server.json

error TS2688: Cannot find type definition file for '@angular/localize'.
- Project Scope

packages/angular_devkit/build_angular/test/hello-world-app/src/tsconfig.spec.json

error TS2688: Cannot find type definition file for '@angular/localize'.
- Project Scope
error TS2688: Cannot find type definition file for 'jasmine'.
- Project Scope

packages/angular_devkit/build_angular/test/hello-world-lib/projects/lib/tsconfig.spec.json

error TS2688: Cannot find type definition file for 'jasmine'.
- Project Scope

typescript-bot · 2023-03-06T23:49:44Z

compiler-explorer/compiler-explorer

2 of 5 projects failed to build with the old tsc and were ignored

cypress/tsconfig.json

error TS2688: Cannot find type definition file for 'chai-http'.
- Project Scope

tsconfig.json

error TS2688: Cannot find type definition file for 'chai-http'.
- Project Scope

typescript-bot · 2023-03-06T23:49:44Z

infinitered/ignite

boilerplate/tsconfig.json

error TS2345: Argument of type '[never, never]' is not assignable to parameter of type 'never'.
- boilerplate/app/navigators/navigationUtilities.ts#L156

typescript-bot · 2023-03-06T23:49:45Z

Molunerfinn/PicGo

tsconfig.json

error TS2688: Cannot find type definition file for 'element-plus/global'.
- Project Scope
error TS2688: Cannot find type definition file for 'vue3-photo-preview'.
- Project Scope
error TS2688: Cannot find type definition file for 'webpack-env'.
- Project Scope

typescript-bot · 2023-03-06T23:49:46Z

pmndrs/jotai

3 of 7 projects failed to build with the old tsc and were ignored

examples/mega-form/tsconfig.json

error TS2589: Type instantiation is excessively deep and possibly infinite.
- examples/mega-form/src/App.tsx#L17

typescript-bot · 2023-03-06T23:49:47Z

tldraw/tldraw

13 of 20 projects failed to build with the old tsc and were ignored

packages/vec/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
- Project Scope in packages/vec/tsconfig.build.json
error TS2688: Cannot find type definition file for '@testing-library/react'.
- Project Scope in packages/vec/tsconfig.build.json

packages/vec/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
- Project Scope in packages/vec/tsconfig.dev.json
error TS2688: Cannot find type definition file for '@testing-library/react'.
- Project Scope in packages/vec/tsconfig.dev.json

packages/intersect/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
- Project Scope in packages/vec/tsconfig.json
error TS2688: Cannot find type definition file for '@testing-library/react'.
- Project Scope in packages/vec/tsconfig.json

packages/intersect/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
- Project Scope in packages/vec/tsconfig.json
error TS2688: Cannot find type definition file for '@testing-library/react'.
- Project Scope in packages/vec/tsconfig.json

packages/curve/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
- Project Scope in packages/curve/tsconfig.build.json
error TS2688: Cannot find type definition file for '@testing-library/react'.
- Project Scope in packages/curve/tsconfig.build.json

packages/curve/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
- Project Scope in packages/curve/tsconfig.dev.json
error TS2688: Cannot find type definition file for '@testing-library/react'.
- Project Scope in packages/curve/tsconfig.dev.json

packages/curve/tsconfig.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.
- Project Scope in packages/curve/tsconfig.json
error TS2688: Cannot find type definition file for '@testing-library/react'.
- Project Scope in packages/curve/tsconfig.json

typescript-bot · 2023-03-06T23:49:48Z

trufflesuite/truffle

10 of 43 projects failed to build with the old tsc and were ignored

packages/blockchain-utils/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.
- Project Scope
error TS2688: Cannot find type definition file for 'node'.
- Project Scope

packages/config/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.
- Project Scope
error TS2688: Cannot find type definition file for 'node'.
- Project Scope

packages/from-hardhat/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.
- Project Scope

packages/hdwallet/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.
- Project Scope

DanielRosenwasser · 2023-03-07T01:16:29Z

@sheetalkamat I think #51715 affected many of these, and I believe (most of?) these are configured correctly. Could you take a look?

sheetalkamat · 2023-03-07T18:00:32Z

Taking look.

sheetalkamat · 2023-03-07T20:47:28Z

compiler-explorer/compiler-explorer

2 of 5 projects failed to build with the old tsc and were ignored

cypress/tsconfig.json

error TS2688: Cannot find type definition file for 'chai-http'.

Project Scope

tsconfig.json

error TS2688: Cannot find type definition file for 'chai-http'.

Project Scope

https://github.com/compiler-explorer/compiler-explorer/blob/dd2c08693cd8d4682e2003eeff4d3dab3d870493/cypress/tsconfig.json#L9 needs to include "../node_modules" as well in typeRoots

https://github.com/compiler-explorer/compiler-explorer/blob/dd2c08693cd8d4682e2003eeff4d3dab3d870493/tsconfig.backend.json#L13 needs to include "node_modules" in typeRoots

sheetalkamat · 2023-03-07T20:48:50Z

angular/angular-cli

7 of 19 projects failed to build with the old tsc and were ignored

packages/angular_devkit/build_angular/test/hello-world-app/e2e/tsconfig.e2e.json

error TS2688: Cannot find type definition file for 'jasmine'.

Project Scope

error TS2688: Cannot find type definition file for 'node'.

Project Scope

packages/angular_devkit/build_angular/test/hello-world-app/src/tsconfig.server.json

error TS2688: Cannot find type definition file for '@angular/localize'.

Project Scope

packages/angular_devkit/build_angular/test/hello-world-app/src/tsconfig.spec.json

error TS2688: Cannot find type definition file for '@angular/localize'.

Project Scope

error TS2688: Cannot find type definition file for 'jasmine'.

Project Scope

packages/angular_devkit/build_angular/test/hello-world-lib/projects/lib/tsconfig.spec.json

error TS2688: Cannot find type definition file for 'jasmine'.

Project Scope

These have missing package.json so the typeRoots specified dont contain @types which before would just go and fallback and resolve from ancestor node_modules

sheetalkamat · 2023-03-07T20:58:21Z

Molunerfinn/PicGo

tsconfig.json

error TS2688: Cannot find type definition file for 'element-plus/global'.

Project Scope

error TS2688: Cannot find type definition file for 'vue3-photo-preview'.

Project Scope

error TS2688: Cannot find type definition file for 'webpack-env'.

Project Scope

This needs change to tsconfig.json typeRoots as:

sheetalkamat · 2023-03-07T23:32:33Z

tldraw/tldraw

13 of 20 projects failed to build with the old tsc and were ignored

packages/vec/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.

Project Scope in packages/vec/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/react'.

Project Scope in packages/vec/tsconfig.build.json

packages/vec/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.

Project Scope in packages/vec/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/react'.

Project Scope in packages/vec/tsconfig.dev.json

packages/intersect/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.

Project Scope in packages/vec/tsconfig.json

error TS2688: Cannot find type definition file for '@testing-library/react'.

Project Scope in packages/vec/tsconfig.json

packages/intersect/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.

Project Scope in packages/vec/tsconfig.json

error TS2688: Cannot find type definition file for '@testing-library/react'.

Project Scope in packages/vec/tsconfig.json

packages/curve/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.

Project Scope in packages/curve/tsconfig.build.json

error TS2688: Cannot find type definition file for '@testing-library/react'.

Project Scope in packages/curve/tsconfig.build.json

packages/curve/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.

Project Scope in packages/curve/tsconfig.dev.json

error TS2688: Cannot find type definition file for '@testing-library/react'.

Project Scope in packages/curve/tsconfig.dev.json

packages/curve/tsconfig.json

error TS2688: Cannot find type definition file for '@testing-library/jest-dom'.

Project Scope in packages/curve/tsconfig.json

error TS2688: Cannot find type definition file for '@testing-library/react'.

Project Scope in packages/curve/tsconfig.json

This one needs further fixing. If looking into node_modules/@types we need to handle scoped package names.

sheetalkamat · 2023-03-08T00:11:42Z

trufflesuite/truffle

10 of 43 projects failed to build with the old tsc and were ignored

packages/blockchain-utils/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.

Project Scope

error TS2688: Cannot find type definition file for 'node'.

Project Scope

packages/config/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.

Project Scope

error TS2688: Cannot find type definition file for 'node'.

Project Scope

packages/from-hardhat/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.

Project Scope

packages/hdwallet/tsconfig.json

error TS2688: Cannot find type definition file for 'mocha'.

Project Scope

This needs fixing typeRoots in tsconfig to correct paths eg.

DanielRosenwasser mentioned this issue Mar 7, 2023

🤖 Pick PR #52984 (Check for strict subtypes and then ...) into release-5.0 #53085

Merged

Andarist mentioned this issue Mar 7, 2023

Fixed a cast of arguments passed to navigate infinitered/ignite#2393

Merged

This was referenced Mar 7, 2023

[Bug]: tsconfig.json needs to fix typeRoots for the project Molunerfinn/PicGo#1082

Closed

[BUG]: Needs fix to typeRoots for the project compiler-explorer/compiler-explorer#4831

Open

This was referenced Mar 7, 2023

Handle scoped package resolution from custom type roots #53154

Closed

Add package.json so that custom typeroots location is present and can resolve the types angular/angular-cli#24822

Closed

sheetalkamat mentioned this issue Mar 8, 2023

Fix typeRoots for tsconfig.json trufflesuite/truffle#5956

Merged

2 tasks

RyanCavanaugh closed this as completed Mar 9, 2023

[NewErrors] 5.1.0-dev.20230306 vs 5.0.1-rc #53122

[NewErrors] 5.1.0-dev.20230306 vs 5.0.1-rc #53122

Comments

typescript-bot commented Mar 6, 2023

Investigation Status

typescript-bot commented Mar 6, 2023

typescript-bot commented Mar 6, 2023

typescript-bot commented Mar 6, 2023

typescript-bot commented Mar 6, 2023

typescript-bot commented Mar 6, 2023

typescript-bot commented Mar 6, 2023

typescript-bot commented Mar 6, 2023

DanielRosenwasser commented Mar 7, 2023

sheetalkamat commented Mar 7, 2023

sheetalkamat commented Mar 7, 2023 • edited Loading

sheetalkamat commented Mar 7, 2023 • edited Loading

sheetalkamat commented Mar 7, 2023 • edited Loading

sheetalkamat commented Mar 7, 2023 • edited Loading

sheetalkamat commented Mar 8, 2023

sheetalkamat commented Mar 7, 2023 •

edited

Loading

sheetalkamat commented Mar 7, 2023 •

edited

Loading

sheetalkamat commented Mar 7, 2023 •

edited

Loading

sheetalkamat commented Mar 7, 2023 •

edited

Loading