runtests-watch runs nothing in modern Node

[Peeja]

Bug Report

🔎 Search Terms

runtests-watch, uv_signal_start EINVAL, SIGKILL

🕗 Version & Regression Information

Haven't bothered to try this outside of main, as it's only a tooling issue.

⏯ Playground Link

N/A, purely dev tooling.

💻 Code

$ hereby runtests-watch --tests=tests/cases/compiler/2dArrays.ts                                                                                                                     

🙁 Actual behavior

Errors immediately and runs nothing:

Using ~/git/TypeScript/Herebyfile.mjs to run runtests-watch
Starting generate-diagnostics
> /Users/peeja/.nvm/versions/node/v16.14.2/bin/node scripts/processDiagnosticMessages.mjs src/compiler/diagnosticMessages.json
Starting lib
Reading diagnostics from src/compiler/diagnosticMessages.json
Finished lib in 78ms
Finished generate-diagnostics in 126ms
Starting watch-tests
Warning: watch mode is incomplete and may not work as expected. Use at your own risk.
Finished watch-tests in 13ms
[watch] build finished, watching for changes...
Starting runtests-watch
Error in runtests-watch in 5ms
Error: uv_signal_start EINVAL
Completed runtests-watch with errors in 145ms

🙂 Expected behavior

Runs the tests:

Using ~/git/TypeScript/Herebyfile.mjs to run runtests-watch
Starting generate-diagnostics
> /Users/peeja/.nvm/versions/node/v16.14.2/bin/node scripts/processDiagnosticMessages.mjs src/compiler/diagnosticMessages.json
Starting lib
Reading diagnostics from src/compiler/diagnosticMessages.json
Finished lib in 79ms
Finished generate-diagnostics in 110ms
Starting watch-tests
Warning: watch mode is incomplete and may not work as expected. Use at your own risk.
[watch] build finished, watching for changes...
Finished watch-tests in 14ms
Starting runtests-watch
[watch] cleaning test directories...
[watch] running tests...
<...test output...>

Reason

Error: uv_signal_start EINVAL is throwing because we're trying to listen for a SIGKILL, which is nonsensical (as your handler will never have a chance to run) and expressly disallowed in newer Node versions.

[fatcerberus]

And by "newer Node versions" it seems you mean "anything from 2013 or later" 😜
Isn't TypeScript itself newer than that?

[jakebailey]

Yes, I'm a little confused; the versions listed in that post long predate us adding this watch mode, and I have never seen this crash.